Fix permissions for updating earned certifications #2495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we checked the owner of the passed in object, but not the owner of the db object in the case of an update. This meant that people could effectively change ownership of earned certifications from someone else to themselves. This commit makes the change so we check both the object in flight, and the object at rest for updates.
timyates
added
bug
timyates
commented
Jun 12, 2024
Contributor
Author
There was a problem hiding this comment.
I also changed the join from LEFT JOIN to JOIN, this is a no-op I believe as there cannot be one without the other, however JOIN is more correct
mkimberlin
approved these changes
Jun 12, 2024
mvolkmann
approved these changes
Jun 12, 2024
vhscom
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we checked the owner of the passed in object, but not the owner of the db object in the case of an update.
This meant that people could effectively change ownership of earned certifications from someone else to themselves.
This commit makes the change so we check both the object in flight, and the object at rest for updates.