Remove the Mono.xxx wrapping from the controllers #2499
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have many places where we are wrapping the responses in a Mono in the controllers. As we declare `@ExecuteOn(TaskExecutors.BLOCKING)` in these controllers, I don't think this is required. And it probably affects performance, as the work is probably offloaded multiple times to multiple thread pools. This commit removes (almost) all of the wrapping. The only place it remains is in the Github client (as I'm not currently sure where that's used) 🤔
mkimberlin
approved these changes
Jun 14, 2024
vhscom
approved these changes
Jun 17, 2024
Contributor
vhscom
left a comment
vhscom
left a comment
There was a problem hiding this comment.
Looks great. This is going to make the codebase much easier to work with.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have many places where we are wrapping the responses in a Mono in the controllers.
As we declare
@ExecuteOn(TaskExecutors.BLOCKING)in these controllers, I don't think this is required.And it probably affects performance, as the work is probably offloaded multiple times to multiple thread pools.
This commit removes (almost) all of the wrapping. The only place it remains is in the Github client (as I'm not currently sure where that's used) 🤔