Remove instance booleans and fix conditionals #2506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where possible this commit switches from `Boolean` class parameters to primitive booleans. The problem with `Boolean` is that it introduces 3 states, TRUE, FALSE and null. And if you have a comparator such as `if (svc.returnsBoolean())` and the method returns null, you get a NPE
vhscom
approved these changes
Jun 17, 2024
mkimberlin
approved these changes
Jun 18, 2024
Member
mkimberlin
left a comment
mkimberlin
left a comment
There was a problem hiding this comment.
I'm not going to lie. This makes me a little sad. I have a personal hatred of primitives in Java.
Contributor
Author
|
Unexpected NullPointerExceptions are worse imho 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where possible this commit switches from
Booleanclass parameters to primitive booleans.The problem with
Booleanis that it introduces 3 states,TRUE,FALSEandnull.Where the contract has a Nullable requirement, I have updated the
ifstatements, asif (obj.nullableMember()) {will throw a null pointer exception if the Boolean result isnull. The safe replacement isif (Boolean.TRUE.equals(obj.nullableMember())) {