Front-end import cleanup #2517
Merged
Front-end import cleanup #2517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having the same module imported multiple times can affect code readability and maintainability.
These imports do not contribute to the functionality of the application and only add extra weight to the JavaScript bundle, leading to potential performance and maintainability issues.
mvolkmann
reviewed
Jun 19, 2024
| @@ -1,20 +1,21 @@ | |||
| import React, { useContext, useEffect, useState, useRef } from 'react'; | |||
| import { styled } from '@mui/material/styles'; | |||
| import './FeedbackRecipientSelector.css'; | |||
Collaborator
There was a problem hiding this comment.
At first I thought this import was removed, but I see now that it was just moved down. That's fine.
Contributor
Author
There was a problem hiding this comment.
Yeah, I tried to arrange them all to kind of match each other... In the main the css import comes just prior to the const values
Collaborator
There was a problem hiding this comment.
That matches my preference.
mvolkmann
approved these changes
Jun 19, 2024
vhscom
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clears up 80 warnings issued by Sonar around imports in the React code in 2 commits (might be easier to review each commit separately)
Imports from the same module should be merged
Unnecessary imports should be removed