Bugfix sonar next round #2538
Merged
Bugfix sonar next round #2538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You get more safety as a missing value will cause the build to fail
- We don't need to test for null - extract validation of skills and members into separate methods - switch conditionals to check the positive not negative (ie: if(a)else instead of if(!a)else)
- extract out a method to build the final map - use computeIfAbsent instead of complex if with lists and stuff
timyates
commented
Jul 8, 2024
Comment on lines
-166
to
-171
| if (frequency == FrequencyType.DAILY) { | ||
| beginningDate = dateToStudy.minusDays(1); | ||
| } else if (frequency == FrequencyType.WEEKLY) { | ||
| beginningDate = dateToStudy.minusMonths(1); | ||
| } else { | ||
| beginningDate = dateToStudy.minusMonths(1); |
Contributor
Author
There was a problem hiding this comment.
WEEKLY is dateToStudy.minusMonths(1)
But so is the default (MONTHLY)... is this right?
Member
There was a problem hiding this comment.
Yeah, not going to lie...I don't think this bit of logic is right. I think some wires got crossed on this bit of fuctionality. I need to go back and find the original task and create some bug fix stories. Luckily this bit doesn't have a UI yet.
mkimberlin
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few more sonar fixes here, again one by one for ease of reviewing:
!collection.isEmpty()instead ofcollection.size() > 0as it expresses intent betterWhere there's a fixed number of possible outcomes, it's recommended to use switch expressions as any un-tested branches when a new value is added will throw a compilation error
!Boolean.TRUE.equals(v)Sometimes methods can end up too busy and become hard to follow in your head. Method extraction can help simplify these.
anyMatchon stream instead offilter.findFirst.isPresent