Limit emails sent by GuildMemberServices #2551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When GuildMemberServices save or delete is called from the GuildMemberController, we want to send an email. However when these methods are called from the GuildServices we don't, as this email is sent by GuildServices. This PR adds a flag as to whether an email should be sent, and fixes the mockito in the tests to ensure a single email is sent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When GuildMemberServices save or delete is called from the GuildMemberController, we want to send an email.
However when these methods are called from the GuildServices we don't, as this email is sent by GuildServices.
This PR adds a flag as to whether an email should be sent, and fixes the mockito in the tests to ensure a single email is sent
Closes #2549