Feature 2571/merit evaluation report #2586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmation" per member.
…doc (not yet functional).
… QuestionServices.
… infer the type based on file name.
mkimberlin
reviewed
Sep 10, 2024
| | | ||
| TemplateQuestion | | ||
| - id <--------------+ | ||
| - question |
Member
There was a problem hiding this comment.
Guessing you didn't mean to leave this in here...
Collaborator
Author
There was a problem hiding this comment.
I actually did. But, we can remove it. I just thought it might be helpful to someone else if they came in and tried to understand how feedback related objects fit together.
17 tasks
timyates
reviewed
Sep 16, 2024
server/src/main/java/com/objectcomputing/checkins/services/reports/ReportHours.java
Outdated
Show resolved
Hide resolved
timyates
reviewed
Sep 16, 2024
server/src/main/java/com/objectcomputing/checkins/services/reports/ReportKudos.java
Outdated
Show resolved
Hide resolved
timyates
reviewed
Sep 16, 2024
...er/src/test/java/com/objectcomputing/checkins/services/reports/ReportDataControllerTest.java
Show resolved
Hide resolved
timyates
reviewed
Sep 16, 2024
server/src/main/java/com/objectcomputing/checkins/services/reports/CurrentInformation.java
Outdated
Show resolved
Hide resolved
timyates
reviewed
Sep 16, 2024
server/src/main/java/com/objectcomputing/checkins/services/reports/CurrentInformation.java
Outdated
Show resolved
Hide resolved
timyates
reviewed
Sep 16, 2024
server/src/main/java/com/objectcomputing/checkins/services/reports/CurrentInformation.java
Outdated
Show resolved
Hide resolved
timyates
reviewed
Sep 16, 2024
server/src/main/java/com/objectcomputing/checkins/services/reports/CurrentInformation.java
Outdated
Show resolved
Hide resolved
timyates
approved these changes
Sep 17, 2024
Contributor
timyates
left a comment
timyates
left a comment
There was a problem hiding this comment.
I hope no-one minds, I pushed a few changes instead of flagging them up for review (a few unused imports, and aligning the style of the 3 CSVProcessors)
Not checked the front end, but the back end lgtm now 😁
Only thing is some of the files use 2 spaces for indent, and some use 4, but that's me being picky 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the upload of CSV data, download of report data, and creation of merit reports uploaded to Google Drive.