Feature 2349/bi weekly pulse emails #2588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to use MJML to create the email. But, it was going to take a lot of effort to support that. I attempted translation of MJML to HTML. But, that didn't look so great. I ended up creating the HTML directly.
It's configurable to weekly, bi-weekly, and monthly. The settings page didn't actually work and required a bit of work to allow us to save settings in the database. I'm not super happy with the settings. As written, it doesn't support using a set of valid values and creating a drop-down, which is what we really needed. So, the user has to type in the setting value, which allows for user error to make it to the server.