-
Notifications
You must be signed in to change notification settings - Fork 6
Feature 2550/rewire review page #2606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eriods relating to member addition and removal.
…w periods can be viewed with links to review feedback.
…of the members she supervises.
…od state to Open.
…ated with the review period.
… self-review and review for permissions of current user.
…an be created, if necessary.
Closed
thelenw
reviewed
Sep 25, 2024
...er/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodServicesImpl.java
Outdated
Show resolved
Hide resolved
thelenw
reviewed
Sep 25, 2024
...er/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodServicesImpl.java
Outdated
Show resolved
Hide resolved
thelenw
reviewed
Sep 25, 2024
...er/src/main/java/com/objectcomputing/checkins/services/reviews/ReviewPeriodServicesImpl.java
Outdated
Show resolved
Hide resolved
thelenw
reviewed
Sep 25, 2024
thelenw
reviewed
Sep 25, 2024
| setAssignments(assignments.filter(a => | ||
| !(a.revieweeId === revieweeId && a.reviewerId === reviewerId))); | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const { id, revieweeId, reviewerId } = assignment;
if (id) {
try {
const res = await resolve({
method: 'DELETE',
url: `${reviewAssignmentsUrl}/${id}`,
headers: { 'X-CSRF-Header': csrf }
});
if (res.error) {
console.error('Error deleting assignment:', res.error);
return;
}
// Update state by removing the assignment by id
setAssignments(prevAssignments => prevAssignments.filter(a => a.id !== id));
} catch (error) {
console.error('Request failed:', error);
}
} else {
// If there's no id, remove by matching revieweeId and reviewerId
setAssignments(prevAssignments =>
prevAssignments.filter(a => !(a.revieweeId === revieweeId && a.reviewerId === reviewerId))
);
}
thelenw
reviewed
Sep 25, 2024
thelenw
approved these changes
Sep 25, 2024
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments with code blocks, and without text, are recommended refactors.
… and/or transitioning to different stages. Additionally, cleaned up code based on the review from @thelenw
mkimberlin
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was more complicated than I expected. With these changes, we can now view open review periods. Managers can see the status of reviews and can view submitted self-reviews and reviews of their subordinates.