-
Notifications
You must be signed in to change notification settings - Fork 6
Volunteer Tracking Bugfixes #2647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mkimberlin
merged 15 commits into
develop
from
feature-2647/volunteer-tracking-bugfixes
Oct 22, 2024
Merged
Volunteer Tracking Bugfixes #2647
mkimberlin
merged 15 commits into
develop
from
feature-2647/volunteer-tracking-bugfixes
Oct 22, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkimberlin
reviewed
Oct 18, 2024
server/src/main/resources/db/common/V107__create_volunteering_tables.sql
Show resolved
Hide resolved
0763c2d to
e543403
Compare
20c9847 to
58e5f70
Compare
8f21ce4 to
b744ffc
Compare
thelenw
commented
Oct 21, 2024
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make Start Date nullable:
- Allow empty start_date field
- Make the field nullable for all server endpoints
- Update UI to reflect
- Fix tests
mkimberlin
reviewed
Oct 21, 2024
server/src/main/resources/db/common/V115__alter_volunteering_relationship.sql
Show resolved
Hide resolved
ea92f7a to
8d42189
Compare
mkimberlin
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
Allow and properly reflect empty Start Date field when User creates a relationship with an organization thus.
Details
Changes to frontend @
src/components/volunteerto support Users creating & editing volunteer organization entries with no start date.Changes to backend @
main/java/com/objectcomputing/checkins/services/volunteeringto support nullable Start Date.Changes to migration 107 to allow nullable Start Date in the database.