`EObytes$EOslice` fails when input is wrong

[yegor256]

I see this:

  ⇢ 1022) o.e.PhDefault#take():160
  ⇢ 1023) o.e.AtomSafe#lambda():49
  ⇢ 1024) E.E.EObytes$EOslice#lambda():81
  ⇢ 1025) j.u.Arrays#copyOfRange():3853
  ⇢ 1026) j.l.System#arraycopy():-2
  ⇢ 1027) "arraycopy: length -7 is negative"

However, we have all the proper checks there. Why don't they detect incorrect input?

[yegor256]

@jacks-sam1010 Latta, you are is almost there! This is how the method should look:

    @Override
    public Phi lambda() {
        final byte[] array = new Dataized(this.take(Attr.RHO)).take();
        final int start = Expect.at(this, "start")
            .that(phi -> new Dataized(phi).asNumber())
            .otherwise("must be a number")
            .must(number -> number % 1 == 0)
            .that(Double::intValue)
            .otherwise("must be an integer")
            .must(integer -> integer >= 0)
            .otherwise("must be a positive integer")
            .must(integer -> integer < array.length)
            .otherwise(String.format("must be lt %d", array.length))
            .it();
        final int length = Expect.at(this, "len")
            .that(phi -> new Dataized(phi).asNumber())
            .otherwise("must be a number")
            .must(number -> number % 1 == 0)
            .that(Double::intValue)
            .otherwise("must be an integer")
            .must(integer -> integer >= 0)
            .otherwise("must be a positive integer")
            .must(integer -> start + integer <= array.length)
            .otherwise(String.format("must be lte %d minus %d", array.length, start))
            .it();
        return new Data.ToPhi(
            Arrays.copyOfRange(
                array,
                start, start + length
            )
        );
    }

However, with these changes 12 tests fail. Let's fix them.

[maxonfjvipon]

@yegor256 still an issue? This is how EObytes$EOslice looks now:

@XmirObject(oname = "bytes.slice")
@SuppressWarnings("PMD.AvoidDollarSigns")
public final class EObytes$EOslice extends PhDefault implements Atom {
    /**
     * Ctor.
     */
    @SuppressWarnings("PMD.ConstructorOnlyInitializesOrCallOtherConstructors")
    public EObytes$EOslice() {
        this.add("start", new AtVoid("start"));
        this.add("len", new AtVoid("len"));
    }

    @Override
    public Phi lambda() {
        final int start = Expect.at(this, "start")
            .that(phi -> new Dataized(phi).asNumber())
            .otherwise("must be a number")
            .must(number -> number % 1 == 0)
            .that(Double::intValue)
            .otherwise("must be an integer")
            .must(integer -> integer >= 0)
            .otherwise("must be a positive integer")
            .it();
        final int length = Expect.at(this, "len")
            .that(phi -> new Dataized(phi).asNumber())
            .otherwise("must be a number")
            .must(number -> number % 1 == 0)
            .that(Double::intValue)
            .otherwise("must be an integer")
            .must(integer -> integer >= 0)
            .otherwise("must be a positive integer")
            .it();
        return new Data.ToPhi(
            Arrays.copyOfRange(
                new Dataized(this.take(Phi.RHO)).take(),
                start, start + length
            )
        );
    }
}