feat(#248): application-duality#249
Merged
yegor256 merged 5 commits intoobjectionary:masterfrom Jan 17, 2025
Merged
Conversation
Member
Author
|
@maxonfjvipon please check this one |
maxonfjvipon
suggested changes
Jan 16, 2025
| <xsl:output encoding="UTF-8" method="xml"/> | ||
| <xsl:template match="/"> | ||
| <defects> | ||
| <xsl:for-each select="//o"> |
Member
There was a problem hiding this comment.
@h1alexbel abstract objects should not be processed here, which means they must have @base
| sheets: | ||
| - /org/eolang/lints/critical/application-duality.xsl | ||
| asserts: | ||
| - /defects[count(defect[@severity='critical'])=1] |
Member
There was a problem hiding this comment.
@h1alexbel it seems 2 defects must be caught here, one for man, one for car
Member
Author
|
@maxonfjvipon updated. Take a look, please |
Member
Author
|
@maxonfjvipon reminder |
maxonfjvipon
approved these changes
Jan 17, 2025
Member
Author
|
@yegor256 please check |
Member
|
@h1alexbel thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I've implemented
application-dualitylint that issuescriticaldefect if object has an application with duality (@asattributes presence is mixed).closes #248
History: