Skip to content

feat(#879): extract name-validation logic into Vocabulary class#883

Merged
rultor merged 4 commits into
objectionary:masterfrom
volodya-lombrozo:879-name-validation
May 25, 2026
Merged

feat(#879): extract name-validation logic into Vocabulary class#883
rultor merged 4 commits into
objectionary:masterfrom
volodya-lombrozo:879-name-validation

Conversation

@volodya-lombrozo
Copy link
Copy Markdown
Member

Extracts name-validation logic from LtTestNotVerb into a dedicated Vocabulary class and moves the comprehensive parametrized tests there, keeping LtTestNotVerbTest lean with only a few representative end-to-end cases.

Fixes #879

@volodya-lombrozo
Copy link
Copy Markdown
Member Author

@rultor merge

@rultor
Copy link
Copy Markdown
Contributor

rultor commented May 25, 2026

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor rultor merged commit 79e4eca into objectionary:master May 25, 2026
21 checks passed
@rultor
Copy link
Copy Markdown
Contributor

rultor commented May 25, 2026

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 6min).

@0crat
Copy link
Copy Markdown

0crat commented May 26, 2026

@volodya-lombrozo Thanks for the contribution! You've earned +12 points for this: +16 as a basis, +16.95 for your 339 hits-of-code (339 × 0.05), but -4 deducted since you exceeded 100 hits-of-code and -16.95 to cap the HoC bonus at 16 points maximum. According to our policy, contributions over 100 hits-of-code receive penalties to encourage quality over quantity. Your running score is +295 - keep up the great work and don't forget to check your Zerocracy account! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Name-validation extraction in LtTestNotVerbTest.java not functioning as expected

3 participants