feat(#879): extract name-validation logic into Vocabulary class#883
Merged
rultor merged 4 commits intoMay 25, 2026
Conversation
…ode in VocabularyTest
Member
Author
|
@rultor merge |
Contributor
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here. |
Contributor
@volodya-lombrozo Done! FYI, the full log is here (took me 6min). |
|
@volodya-lombrozo Thanks for the contribution! You've earned +12 points for this: +16 as a basis, +16.95 for your 339 hits-of-code (339 × 0.05), but -4 deducted since you exceeded 100 hits-of-code and -16.95 to cap the HoC bonus at 16 points maximum. According to our policy, contributions over 100 hits-of-code receive penalties to encourage quality over quantity. Your running score is +295 - keep up the great work and don't forget to check your Zerocracy account! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts name-validation logic from
LtTestNotVerbinto a dedicatedVocabularyclass and moves the comprehensive parametrized tests there, keepingLtTestNotVerbTestlean with only a few representative end-to-end cases.Fixes #879