This repository was archived by the owner on Oct 23, 2024. It is now read-only.
Implementing Acl Sync #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ances via ApiV2. Fixing failing auth tests. Using responses library for mocking/testing api requests. Proper tests for get/set/run acl sync. Completes #22
Contributor
Author
|
Python3 is failing here. I'll fix. |
Contributor
Author
|
Py3.x Fixed! |
objectrocket/bases.py
Outdated
Contributor
There was a problem hiding this comment.
You can also say json=data and the requests lib will JSON encode the dict for you. Convenient, but not critical.
Contributor
Author
There was a problem hiding this comment.
This is nice to know... Removed that import and adjusted those calls.
Contributor
|
Have a linter PR pointed to this PR for a merge. Will expose some static code issues which the linter was ignoring (it was technically ignoring everything). My misconfiguration of the linter from a while back, to be sure. |
Contributor
|
+1 will address linter issues in separate PR. Merge at will. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.