Conversation
Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/5a66f9ed-ffcd-4354-bde2-95cadad7e3ca Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/5a66f9ed-ffcd-4354-bde2-95cadad7e3ca Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
Claude created this pull request from a session on behalf of
xuyushun441-sys
April 9, 2026 08:44
View session
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Reorders Studio kernel plugin initialization so SetupPlugin registers the setupNav service before other plugins attempt to contribute Setup navigation during their init() lifecycle, restoring non-empty Setup app navigation.
Changes:
- Load
SetupPluginbefore contributor plugins in the Studio server kernel bootstrap. - Apply the same ordering in the Studio mock/test kernel factory, with an explanatory comment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/studio/server/index.ts | Moves SetupPlugin earlier so setupNav exists before Auth/Security/Audit/AI plugins contribute nav items. |
| apps/studio/src/mocks/createKernel.ts | Aligns mock kernel plugin ordering with production to ensure Setup navigation contributions are captured in tests/browser mocks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup app returned empty navigation areas despite plugins registering menu items via
setupNav.contribute(). The service contribution pattern requires the provider plugin to initialize before consumers.Changes
SetupPlugininitialization beforeAuthPlugin,SecurityPlugin,AuditPlugin, andAIServicePluginContext
The SetupPlugin registers a
setupNavservice duringinit()that other plugins consume to contribute navigation items:When SetupPlugin loaded last, the service didn't exist during other plugins'
init()phase, causing all contributions to silently fail.Result
Setup app now displays navigation across all areas: