Skip to content

fix(app-host): add Hono import to api entrypoint and .npmrc for Vercel deployment #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Apr 14, 2026
+4 −1
Merged

fix(app-host): add Hono import to api entrypoint and .npmrc for Vercel deployment #1130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
398e7b7
fix(app-host): add Hono import to api entrypoint and .npmrc for Verce…
Claude Apr 14, 2026
8c7af00
fix(app-host): set framework to null in vercel.json to disable automa…
Claude Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/app-host/.npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# Vercel pnpm configuration
# Use hoisted node_modules structure instead of symlinks to avoid Vercel packaging errors.
node-linker=hoisted
Comment on lines +2 to +3
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node-linker=hoisted in examples/app-host/.npmrc likely won’t be picked up by the current Vercel installCommand (cd ../.. && pnpm install), because pnpm reads .npmrc from the current working directory upward (repo root won’t see this file). Consider either moving this setting to the repo root .npmrc, or changing installCommand to run pnpm install from examples/app-host (or passing --config.node-linker=hoisted) so the setting is actually applied during install.

Suggested change
# Use hoisted node_modules structure instead of symlinks to avoid Vercel packaging errors.
node-linker=hoisted
# This example-level .npmrc is not read when Vercel installs dependencies from the repo root
# (for example via `cd ../.. && pnpm install`), so `node-linker=hoisted` must be defined
# in the repo root .npmrc or passed explicitly via the install command instead of here.

Copilot uses AI. Check for mistakes.
2 changes: 1 addition & 1 deletion examples/app-host/vercel.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"$schema": "https://openapi.vercel.sh/vercel.json",
"framework": "hono",
"framework": null,
"installCommand": "cd ../.. && pnpm install",
Comment on lines 2 to 4
Copy link

Copilot AI Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title/description says this fix relies on adding an explicit import 'hono' in api/[[...route]].js, but this PR instead changes vercel.json to "framework": null (disabling Hono framework detection). Please align the approach: either keep framework: "hono" and add the explicit import, or keep framework: null and update the PR title/description to reflect that the fix is to disable framework detection.

Copilot uses AI. Check for mistakes.
"buildCommand": "bash scripts/build-vercel.sh",
"functions": {
Expand Down
Loading