Fix doubly-prefixed FQN for ObjectOS system objects#1200
Merged
xuyushun441-sys merged 1 commit intomainfrom Apr 20, 2026
Merged
Fix doubly-prefixed FQN for ObjectOS system objects#1200xuyushun441-sys merged 1 commit intomainfrom
xuyushun441-sys merged 1 commit intomainfrom
Conversation
…etc.) Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/169d203f-a9cc-4a0b-9869-a45448e64d44 Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
xuyushun441-sys
April 20, 2026 14:55
View session
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ObjectOS system objects were registering under FQNs like
sys__sys_object,sys__sys_view,sys__sys_metadata— thesys_prefix was applied twice because each definition hard-coded it intonamewhile the owning manifest also declarednamespace: 'sys', andSchemaRegistry.computeFQNconcatenates both as{namespace}__{name}.Changes
packages/objectos/src/objects/*.ts— Drop thesys_prefix fromnameso the short name matches the convention used byplugin-auth,plugin-security, and@objectstack/metadata:SysObject.name:sys_object→object(FQNsys__object)SysView.name:sys_view→view(FQNsys__view)SysAgent.name:sys_agent→agent(FQNsys__agent)SysTool.name:sys_tool→tool(FQNsys__tool)SysFlow.name:sys_flow→flow(FQNsys__flow)SysMetadata.name:sys_metadata→metadatapackages/objectos/src/registry.ts— RemoveSysMetadatafrom the auto-registeredSystemObjectscatalog to avoid an ownership collision onsys__metadata, which is already owned by@objectstack/metadata.SysMetadataremains exported for direct import. Record keys updated to the new short names and TSDoc explicitly warns against hard-codingsys_intoname.packages/metadata/src/plugin.ts— Debug log now reports FQNs (sys__object, …) rather than bare short names, which are ambiguous post-fix.sys-metadata.object.test.ts,packages/objectos/README.md, andCHANGELOG.mdupdated.Before / after
Notes for reviewers
SysMetadataand@objectstack/metadata'sSysMetadataObjectmodel the same envelope with divergent field sets. This PR preserves the status quo (metadata package is the owner) and defers reconciliation. IfSysMetadatais meant to supersede it, that should be a separate, explicit migration.sys__sys_*FQNs;plugin-auth,plugin-security,plugin-audit, andhttp-dispatcheralready use correctly-formed FQNs (sys__user,sys__role,sys__audit_log,sys__environment, …).