Skip to content

fix(ci): restore native build scripts broken by duplicate pnpm config#1232

Merged
hotlong merged 1 commit into
mainfrom
copilot/fix-ci-errors-build-test-again
May 7, 2026
Merged

fix(ci): restore native build scripts broken by duplicate pnpm config#1232
hotlong merged 1 commit into
mainfrom
copilot/fix-ci-errors-build-test-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 7, 2026

@objectstack/driver-sql#test was failing in CI with Could not locate the bindings file for better-sqlite3.

Root cause

Commit cca9c402 (MongoDB driver) introduced a pnpm.onlyBuiltDependencies block in package.json containing only mongodb-memory-server. In pnpm v10 this overrides (not merges with) the same key in pnpm-workspace.yaml, so postinstall scripts for better-sqlite3, esbuild, msw, and sharp were silently skipped — leaving better-sqlite3 without its native binding.

Changes

  • pnpm-workspace.yaml — added mongodb-memory-server to the existing onlyBuiltDependencies list.
  • package.json — removed the duplicate pnpm.onlyBuiltDependencies block so the workspace-level list is the single source of truth.
# pnpm-workspace.yaml
onlyBuiltDependencies:
  - better-sqlite3
  - esbuild
  - mongodb-memory-server
  - msw
  - sharp

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectstack-cloud Ready Ready Preview, Comment May 7, 2026 9:15am
objectstack-objectos Ready Ready Preview, Comment May 7, 2026 9:15am
spec Ready Ready Preview, Comment May 7, 2026 9:15am

Request Review

@hotlong hotlong marked this pull request as ready for review May 7, 2026 09:15
@hotlong hotlong merged commit 288e248 into main May 7, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants