Remove redundant field name declarations in object protocol#159
Merged
Remove redundant field name declarations in object protocol#159
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix duplicate name field in object fields protocol
Remove redundant field name declarations in object protocol
Jan 25, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes redundant field name declarations from the object protocol test file. Field names were being specified twice: once as the map key in the fields object, and again as a name property within each field definition. Since ObjectSchema.fields uses z.record(FieldSchema) where map keys serve as field identifiers, and FieldSchema.name is already optional, the duplication was unnecessary.
Changes:
- Removed redundant
nameproperties from all field definitions inobject.test.tswhere fields are defined within an object'sfieldsmap - Maintained proper usage where the
nameproperty is derived from the map key (e.g.,first_name,account_name,subject)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field names were declared twice in the object fields protocol - once as the map key and again as a
nameproperty within the field definition.Before:
After:
Changes
nameproperties from field definitions inobject.test.tsFieldSchema.nameremains optional for standalone field validation use casesExamples and documentation already followed the correct pattern; only test assertions needed alignment.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.