feat(spec): inlineEdit form factor — boolean | 'grid' | 'form'#1636
Merged
Conversation
Master-detail inline editing now selects the entry form factor, not just
on/off. The relationship's `inlineEdit` accepts:
- true → smart default: pick grid/form from the child's shape (rich types
or >~8 fields → form, else grid)
- 'grid' → editable line-item grid (fast bulk entry; thin children)
- 'form' → read-only list; Add / per-row edit opens the child's FULL form
(fat children with rich types — long text, attachments, many fields)
The UI side (resolveInlineMode + grid/list rendering) lives in objectui.
- spec: `field.inlineEdit` widened to `boolean | enum('grid','form')` (true stays valid).
- showcase: `showcase_task.project` pinned to `'grid'` to keep the line-item
grid demo (smart default would otherwise pick `form` for this fat child).
- docs: objectstack-data (Relationships → Inline-edit form factor) and
objectstack-ui (Master-Detail Forms) document the modes + smart default.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Master-detail inline editing now selects the entry form factor, not just on/off.
field.inlineEditaccepts:true→ smart default: pick grid/form from the child's shape (rich types or >~8 fields → form, else grid)'grid'→ editable line-item grid (fast bulk entry; thin children)'form'→ read-only list; Add / per-row edit opens the child's full form (fat children — long text, attachments, many fields)Changes
packages/spec/src/data/field.zod.ts:inlineEditwidened toboolean | enum('grid','form')(truestays valid). Spec rebuilt; field tests 6647 ✓.examples/app-showcase:showcase_task.projectpinned to'grid'to keep the line-item grid demo (smart default would pickformfor this fat child).UI side (resolveInlineMode + grid/list rendering) ships in objectui#feat/inline-edit-mode.
🤖 Generated with Claude Code