feat(showcase): add Invoice + InvoiceLine master-detail demo; drop Task inline entry#1637
Merged
Merged
Conversation
…sk inline entry Auto-embedding a Tasks subtable in New Project felt heavy/odd — a task is added to a project over time, not entered together with it. Remove inlineEdit/inlineTitle from showcase_task.project (keep the read-side relatedList so Tasks still show on the Project detail page). Add the canonical "header + line items" shape where inline entry belongs: Invoice (showcase_invoice) + InvoiceLine (showcase_invoice_line). The line FK declares inlineEdit: 'grid' so New/Edit Invoice renders an editable line-item grid, and the invoice total rolls up the line amounts server-side. Add an Invoices nav entry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
showcase_task is a rich child (notes/location/cover), so with inlineEdit removed from the relationship the master-detail smart default resolves to the per-row `form` factor (read-only list + "Add task" full-form). Update the project-workspace page comment to reflect this; thin children (invoice lines) still get the editable grid. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Auto-embedding a Tasks subtable in New Project felt heavy and odd from an end-user perspective — a task is added to a project over time, not entered together with the project. Inline master-detail entry belongs to true header + line items shapes (invoice + lines), not to a project's task backlog.
What
inlineEdit: 'grid'/inlineTitle: 'Tasks'fromshowcase_task.project. Kept the read-siderelatedListTitle/relatedListColumnsso Tasks still appear on the Project detail page (added later, where they belong).Invoice(showcase_invoice) +InvoiceLine(showcase_invoice_line).showcase_invoice_line.invoiceismasterDetailwithdeleteBehavior: 'cascade',inlineEdit: 'grid',inlineTitle: 'Line Items'.showcase_invoice.totalis asummaryrollup (sum of lineamount) recomputed server-side.Invoicesnav entry to the Showcase app.Verification
showcase_invoice_line.invoice.inlineEdit = "grid"andshowcase_task.project.inlineEditis now absent.🤖 Generated with Claude Code