Skip to content

fix(metadata-protocol): drop internal ADR path from read-only package error#2618

Merged
os-zhuang merged 1 commit into
mainfrom
claude/studio-package-create-ux-jb0f6c
Jul 5, 2026
Merged

fix(metadata-protocol): drop internal ADR path from read-only package error#2618
os-zhuang merged 1 commit into
mainfrom
claude/studio-package-create-ux-jb0f6c

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Summary

Addresses the one framework-side item from #2615 (Studio package-create UX dogfood follow-ups). All other items in that tracking issue are objectui console-side and out of scope here.

  • The writable_package_required rejection thrown when authoring runtime-only metadata into a read-only code/installed package cited an internal doc path (See docs/adr/0070-package-first-authoring.md.), which is meaningless to Studio/API callers.
  • Rewrote the message as user-facing remediation guidance ("it is a read-only package. Switch to or create a writable package, then retry.") instead of pointing at internal ADR docs.

Test plan

  • pnpm --filter @objectstack/metadata-protocol build && pnpm --filter @objectstack/metadata-protocol test — 8/8 passing
  • vitest run test/package-first-authoring.dogfood.test.ts (packages/dogfood) — the golden regression test covering this exact error path — 5/5 passing (asserts on error.code, not message text, so unaffected by the copy change)

🤖 Generated with Claude Code


Generated by Claude Code

… error

The writable_package_required rejection cited docs/adr/0070-package-first-authoring.md,
an internal doc path meaningless to Studio/API users. Rewrite as user-facing
remediation guidance instead.

Fixes #2615 (framework portion; console-side items tracked separately).
@vercel

vercel Bot commented Jul 5, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
spec Ready Ready Preview, Comment Jul 5, 2026 3:07am

Request Review

@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

No hand-written docs reference the 1 changed package(s). ✅

@os-zhuang os-zhuang marked this pull request as ready for review July 5, 2026 06:37
@os-zhuang os-zhuang merged commit 69bc04e into main Jul 5, 2026
16 checks passed
@os-zhuang os-zhuang deleted the claude/studio-package-create-ux-jb0f6c branch July 5, 2026 06:38
os-zhuang pushed a commit that referenced this pull request Jul 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants