[WIP] Update action step configuration for improved performance#301
Merged
[WIP] Update action step configuration for improved performance#301
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot stopped work on behalf of
hotlong due to an error
January 27, 2026 06:39
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a CI build failure in the @objectstack/ai-bridge package by addressing missing dependencies, module resolution configuration, and removing an invalid field type reference.
Changes:
- Added
@objectstack/specas a workspace dependency toai-bridgepackage - Updated TypeScript configuration to use
bundlermodule resolution - Removed invalid
'geolocation'case from field type switch statement
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/ai-bridge/package.json | Added missing @objectstack/spec dependency |
| packages/ai-bridge/tsconfig.json | Added module and moduleResolution overrides for better package.json exports support |
| packages/ai-bridge/src/generator/ts-generator.ts | Removed invalid 'geolocation' field type case |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| "outDir": "./dist", | ||
| "rootDir": "./src" | ||
| "rootDir": "./src", | ||
| "module": "ES2020", |
There was a problem hiding this comment.
The PR description mentions updating moduleResolution to bundler for consistency with objectql package, but doesn't explain why module is being set to ES2020. Consider documenting the reason for this module setting in the PR description or removing it if unnecessary.
Suggested change
| "module": "ES2020", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Build Failure in @objectstack/ai-bridge ✅
Issue
The CI build fails at step 8 (Build packages) with error:
Reference: https://github.com/objectstack-ai/spec/actions/runs/21386032082/job/61562547811#step:8:1
Root Cause
@objectstack/ai-bridgepackage importsFieldTypefrom@objectstack/spec/databut doesn't declare@objectstack/specas a dependency in its package.json.moduleResolution: "node"(inherited from root) which doesn't support package.json exports properly.'geolocation'which doesn't exist in the FieldType enum (only'location'is valid).Changes Made
@objectstack/spec: workspace:*as a dependency topackages/ai-bridge/package.jsonpackages/ai-bridge/tsconfig.jsonto extend root config and overridemoduleResolutionto"bundler"(consistent with objectql package)'geolocation'case from the switch statement ints-generator.tsSecurity Summary
No security vulnerabilities were introduced or discovered.
Files Changed
packages/ai-bridge/package.json- Added @objectstack/spec dependencypackages/ai-bridge/tsconfig.json- Added moduleResolution overridepackages/ai-bridge/src/generator/ts-generator.ts- Removed invalid field typepnpm-lock.yaml- Updated lockfile with new dependencyOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.