Skip to content

Fix Zod schema input types for fields with defaults #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xuyushun441-sys merged 2 commits into from
Jan 27, 2026
Merged

Fix Zod schema input types for fields with defaults #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c4f772
Initial plan
Copilot Jan 27, 2026
88de8a7
Fix TypeScript type errors by using input types in Zod schema defaults
Copilot Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/spec/src/data/object.zod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,14 +97,14 @@ const ObjectSchemaBase = z.object({
* Taxonomy & Organization
*/
tags: z.array(z.string()).optional().describe('Categorization tags (e.g. "sales", "system", "reference")'),
active: z.boolean().default(true).describe('Is the object active and usable'),
isSystem: z.boolean().default(false).describe('Is system object (protected from deletion)'),
abstract: z.boolean().default(false).describe('Is abstract base object (cannot be instantiated)'),
active: z.boolean().optional().default(true).describe('Is the object active and usable'),
isSystem: z.boolean().optional().default(false).describe('Is system object (protected from deletion)'),
abstract: z.boolean().optional().default(false).describe('Is abstract base object (cannot be instantiated)'),

/**
* Storage & Virtualization
*/
datasource: z.string().default('default').describe('Target Datasource ID. "default" is the primary DB.'),
datasource: z.string().optional().default('default').describe('Target Datasource ID. "default" is the primary DB.'),
tableName: z.string().optional().describe('Physical table/collection name in the target datasource'),

/**
Expand Down
3 changes: 2 additions & 1 deletion packages/spec/src/stack.zod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,9 @@ export type ObjectStack = ObjectStackDefinition;

/**
* Type-safe helper to define a project configuration.
* Uses input type to allow optional fields with defaults.
*/
export const defineStack = (config: ObjectStackDefinition) => config;
export const defineStack = (config: z.input<typeof ObjectStackDefinitionSchema>) => config;


/**
Expand Down
4 changes: 2 additions & 2 deletions packages/spec/src/ui/app.zod.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,10 +150,10 @@ export const AppSchema = z.object({
branding: AppBrandingSchema.optional().describe('App-specific branding'),

/** Application status */
active: z.boolean().default(true).describe('Whether the app is enabled'),
active: z.boolean().optional().default(true).describe('Whether the app is enabled'),

/** Is this the default app for new users? */
isDefault: z.boolean().default(false).describe('Is default app'),
isDefault: z.boolean().optional().default(false).describe('Is default app'),

/**
* Navigation Tree Structure.
Expand Down