Skip to content

[WIP] Update action step configuration based on job run#358

Merged
hotlong merged 2 commits intocopilot/update-package-version-to-05from
copilot/update-action-step-configuration-again
Jan 28, 2026
Merged

[WIP] Update action step configuration based on job run#358
hotlong merged 2 commits intocopilot/update-package-version-to-05from
copilot/update-action-step-configuration-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 28, 2026

  • Understand the test failures in plugin.test.ts
  • Make id and version fields optional in PluginSchema
  • Run tests to verify the fix
  • Add documentation explaining the design decision
  • Review and commit changes
Original prompt

引用: https://github.com/objectstack-ai/spec/actions/runs/21434159629/job/61720599376#step:8:1


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
spec Canceled Canceled Jan 28, 2026 10:31am

Request Review

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@hotlong hotlong marked this pull request as ready for review January 28, 2026 10:23
Copilot AI review requested due to automatic review settings January 28, 2026 10:23
@hotlong hotlong merged commit cba6228 into copilot/update-package-version-to-05 Jan 28, 2026
1 of 2 checks passed
Copilot AI requested a review from hotlong January 28, 2026 10:23
Copilot stopped work on behalf of hotlong due to an error January 28, 2026 10:23
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes the id and version fields optional in PluginSchema to fix test failures and allow plugins to be defined with minimal metadata (only lifecycle hooks). The change separates concerns between package identity (handled by ManifestSchema) and runtime plugin behavior (handled by PluginSchema).

Changes:

  • Modified PluginSchema to make id and version fields optional instead of required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants