Fix missing TestSuite type export and unused parameter warnings in QA module#470
Merged
hotlong merged 2 commits intoFeb 2, 2026
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add missing TestSuite type export in testing.zod.ts - Prefix unused context parameters with underscore to satisfy TS6133 - All packages now compile successfully Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix data processing bug in workflow
Fix missing TestSuite type export and unused parameter warnings in QA module
Feb 2, 2026
github-actions
Bot
added
documentation
hotlong
merged commit 73ffbb1
into
copilot/improve-hub-protocol-management
7 checks passed
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes TypeScript compilation errors in the QA testing infrastructure by addressing a missing type export and unused parameter warnings. The changes enable strict TypeScript compilation for the test framework.
Changes:
- Export
TestSuitetype from the QA testing schema to enable proper imports in dependent packages - Prefix unused
contextparameters with underscores in test execution adapters to satisfy TypeScript strict mode - Add auto-generated JSON schemas and documentation for new hub federation and plugin security features
Reviewed changes
Copilot reviewed 64 out of 64 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/spec/src/qa/testing.zod.ts | Adds missing TestSuite type export to match other exported test types |
| packages/core/src/qa/runner.ts | Prefixes unused context parameters in resolveVariables and assert methods |
| packages/core/src/qa/http-adapter.ts | Prefixes unused context parameter in execute method |
| packages/spec/json-schema/hub/*.json | Auto-generated JSON schemas for hub federation and security types |
| packages/spec/json-schema/api/*.json | Auto-generated JSON schemas for hub API request/response types |
| content/docs/references/hub/meta.json | Adds hub-federation and plugin-security to documentation navigation |
| content/docs/references/hub/index.mdx | Adds cards for hub-federation and plugin-security documentation |
| content/docs/references/api/meta.json | Adds hub API to documentation navigation |
| content/docs/references/api/index.mdx | Adds card for hub API documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript compilation was failing with TS2724 (missing export) and TS6133 (unused variable) errors in the QA testing infrastructure.
Changes
packages/spec/src/qa/testing.zod.ts: Export
TestSuitetype alongside other test types (TestScenario,TestStep, etc.). The schema was defined but the type wasn't exported, breaking imports in@objectstack/core.packages/core/src/qa/{http-adapter,runner}.ts: Prefix unused
contextparameters with underscore. The interface requires these parameters for future variable interpolation, but current implementations don't use them yet.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.