feat(core): add replaceService to PluginContext by Copilot · Pull Request #597 · objectstack-ai/framework

Copilot · 2026-02-10T21:43:35Z

Implements upstream spec change §5.1.2 from objectql DESIGN_CORE_REFACTOR.md. The downstream OptimizationsPlugin needs to replace/enhance kernel internals (metadata registry, connection pooling, hook manager), but PluginContext has no service replacement API.

§5.1.1 (Query Profiling) required no changes — OperationContext and EngineMiddleware are already exported.

Changes

PluginContext interface (types.ts): New replaceService<T>(name, implementation) method — throws if service doesn't exist
ObjectKernelBase (kernel-base.ts): Implementation for LiteKernel path (Map + IServiceRegistry)
ObjectKernel (kernel.ts): Implementation with dual-write to services Map + PluginLoader (consistent with existing registerService pattern)
PluginLoader (plugin-loader.ts): replaceService with existence validation
SecurePluginContext (plugin-permission-enforcer.ts): Delegates through permission enforcement via enforceServiceAccess
Tests: 5 new tests across kernel.test.ts and lite-kernel.test.ts (basic replace, missing service error, decorator pattern)

Usage — decorator pattern for optimization plugins

// In OptimizationsPlugin.init():
const existing = ctx.getService('metadata');
const optimized = new OptimizedMetadataRegistry(existing);
ctx.replaceService('metadata', optimized);

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

vercel · 2026-02-10T21:43:42Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
objectstack-play	Ready	Preview, Comment	Feb 10, 2026 10:26pm
spec	Error		Feb 10, 2026 10:26pm

…gration hooks Add replaceService<T>(name, implementation) to PluginContext interface, enabling plugins to replace/enhance kernel internals (metadata registry, hook manager, connection pooling) using the decorator pattern. Implements upstream spec change 5.1.2 from objectql DESIGN_CORE_REFACTOR.md. Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Copilot

Pull request overview

Adds a replaceService() API to PluginContext so plugins (notably optimization/decorator-style plugins) can swap existing kernel services at runtime, aligning core with the upstream refactor spec.

Changes:

Extend PluginContext with replaceService<T>(name, implementation) and wire it through ObjectKernel, ObjectKernelBase (LiteKernel), PluginLoader, and SecurePluginContext.
Implement existence validation + replacement behavior across the kernel and loader.
Add new tests in kernel.test.ts and lite-kernel.test.ts covering basic replacement and error cases.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
packages/core/src/types.ts	Adds `PluginContext.replaceService()` to the public interface.
packages/core/src/kernel.ts	Implements `replaceService()` in the primary kernel context with dual-write + logging.
packages/core/src/kernel-base.ts	Implements `replaceService()` for LiteKernel / base-kernel context.
packages/core/src/plugin-loader.ts	Adds `replaceService()` to update loader-held service instances with existence validation.
packages/core/src/security/plugin-permission-enforcer.ts	Exposes `replaceService()` via `SecurePluginContext` with permission enforcement.
packages/core/src/kernel.test.ts	Adds ObjectKernel tests for service replacement + decorator pattern.
packages/core/src/lite-kernel.test.ts	Adds LiteKernel tests for service replacement + missing-service error.

Copilot · 2026-02-11T01:47:51Z

+     * @param name - Service name to replace
+     * @param implementation - New service implementation
+     * @throws Error if the service does not exist
+     */
+    replaceService<T>(name: string, implementation: T): void;


PluginContext now requires replaceService, but several typed test mocks in the repo construct PluginContext objects without this method (e.g. packages/plugins/plugin-auth/src/auth-plugin.test.ts and packages/core/src/security/plugin-permission-enforcer.test.ts). This will cause TypeScript compile errors; update those mocks to include a replaceService stub (or use a helper factory for PluginContext test doubles).

Suggested change

* @param name - Service name to replace

* @param implementation - New service implementation

* @throws Error if the service does not exist

*/

replaceService<T>(name: string, implementation: T): void;

* NOTE: This is optional for backward compatibility with existing plugins

* and test contexts that may not implement service replacement.

*

* @param name - Service name to replace

* @param implementation - New service implementation

* @throws Error if the service does not exist

*/

replaceService?<T>(name: string, implementation: T): void;

Copilot · 2026-02-11T01:47:52Z

+                    // IServiceRegistry implementation
+                    if (!this.services.has(name)) {
+                        throw new Error(`[Kernel] Service '${name}' not found. Use registerService() to add new services.`);
+                    }


In the IServiceRegistry branch, replaceService calls this.services.register(name, implementation) after confirming the service already exists. IServiceRegistry.register() is specified to throw if the name is already registered, so this path will fail whenever services is an IServiceRegistry. Use unregister(name) (or a dedicated replace/set API) before re-registering.

Suggested change

}

}

// unregister existing service before re-registering to avoid duplicate registration errors

this.services.unregister(name);

Copilot · 2026-02-11T01:47:52Z

+    replaceService(name: string, service: any): void {
+        if (!this.hasService(name)) {
+            throw new Error(`Service '${name}' not found`);
+        }
+        this.serviceInstances.set(name, service);
+    }


PluginLoader.replaceService() sets serviceInstances, but PluginLoader.getService() always prefers a serviceFactory when one exists. That means replacing a service that was registered via registerServiceFactory() will not take effect for async consumers (getService/getServiceAsync). Consider making getService() prefer an explicitly replaced instance, or have replaceService() remove/override the factory registration and clear any scoped caches for that service.

Copilot · 2026-02-11T01:47:52Z

+            replaceService: <T>(name: string, implementation: T): void => {
+                const hasService = this.services.has(name) || this.pluginLoader.hasService(name);
+                if (!hasService) {
+                    throw new Error(`[Kernel] Service '${name}' not found. Use registerService() to add new services.`);
+                }
+                this.services.set(name, implementation);
+                this.pluginLoader.replaceService(name, implementation);
+                this.logger.info(`Service '${name}' replaced`, { service: name });


ObjectKernel’s replaceService currently allows replacement when the service exists only as a factory (via pluginLoader.hasService). However, without additional changes in PluginLoader, the replacement won’t affect kernel.getServiceAsync() (factory path still wins). Either constrain replaceService to instance-registered services only, or update the loader semantics so a replacement overrides factory resolution too.

Copilot · 2026-02-11T01:47:52Z

+  replaceService<T>(name: string, implementation: T): void {
+    // Check permission before replacing service
+    this.permissionEnforcer.enforceServiceAccess(this.pluginName, name);
+    this.baseContext.replaceService(name, implementation);
+  }


SecurePluginContext.replaceService uses enforceServiceAccess, which appears to represent read/access permission. Replacing a service is a much higher-privilege operation (it can hijack kernel internals even if a plugin can only “access” the service). Consider introducing and enforcing a distinct capability for service replacement (or restrict replacement to trusted/core plugins) rather than reusing the read-access check.

Initial plan

47e0e61

Copilot AI assigned Copilot and hotlong Feb 10, 2026

Copilot started work on behalf of hotlong February 10, 2026 21:43 View session

Copilot AI and others added 2 commits February 10, 2026 21:51

fix: add validation to PluginLoader.replaceService for consistency

a5a5742

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add query profiling hook extension point for ObjectQL~~ feat(core): add replaceService to PluginContext Feb 10, 2026

Copilot AI requested a review from hotlong February 10, 2026 21:54

Copilot finished work on behalf of hotlong February 10, 2026 21:54

vercel Bot had a problem deploying to Preview – spec February 10, 2026 22:22 Failure

vercel Bot deployed to Preview – objectstack-play February 10, 2026 22:26 View deployment

hotlong approved these changes Feb 11, 2026

View reviewed changes

hotlong marked this pull request as ready for review February 11, 2026 01:43

Copilot AI review requested due to automatic review settings February 11, 2026 01:43

hotlong merged commit dc6f3a0 into main Feb 11, 2026
2 of 3 checks passed

Copilot started reviewing on behalf of hotlong February 11, 2026 01:43 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(core): add replaceService to PluginContext#597

feat(core): add replaceService to PluginContext#597
hotlong merged 3 commits intomainfrom
copilot/add-query-profiling-hook

Copilot AI commented Feb 10, 2026 •

edited

Loading

Uh oh!

vercel Bot commented Feb 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Copilot AI Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-                    }
+                    }
+                    // unregister existing service before re-registering to avoid duplicate registration errors
+                    this.services.unregister(name);

Conversation

Copilot AI commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Usage — decorator pattern for optimization plugins

Uh oh!

vercel Bot commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 10, 2026 •

edited

Loading

vercel Bot commented Feb 10, 2026 •

edited

Loading