feat(ui): add InterfaceNavItemSchema, disambiguate PageTypeSchema overlaps#697
Merged
hotlong merged 2 commits intocopilot/enhance-ui-protocolfrom Feb 16, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…date design doc decisions Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review design document revisions and evaluate possible merging
feat(ui): add InterfaceNavItemSchema, disambiguate PageTypeSchema overlaps
Feb 16, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements a design review that clarifies the architectural relationship between InterfaceSchema and AppSchema, adds a navigation bridge between them, and disambiguates overlapping page types in the UI protocol. The conclusion is to keep these schemas separate (navigation container ≠ content surface) and provide clear documentation on their distinct purposes.
Changes:
- Added
InterfaceNavItemSchemato enable App navigation items to reference Interfaces (with optional deep-linking to specific pages) - Enhanced
PageTypeSchemaJSDoc with disambiguation comments explaining the differences between similar page types (recordvsrecord_detail,homevsoverview, etc.) - Updated design document with implementation status, decision log entries (#9-11), and Phase A checklist completion
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/spec/src/ui/app.zod.ts |
Added InterfaceNavItemSchema with interfaceName and optional pageName fields to bridge App navigation to Interface content surfaces |
packages/spec/src/ui/app.test.ts |
Added 5 unit tests for InterfaceNavItemSchema validation and 1 integration test showing real-world App↔Interface navigation |
packages/spec/src/ui/page.zod.ts |
Added detailed JSDoc disambiguation comments explaining the 3 overlapping page type pairs and their distinct use cases |
docs/design/airtable-interface-gap-analysis.md |
Updated gap analysis matrix to reflect Phase A implementation, marked Phase A checklist complete, and added 3 decision log entries documenting architectural rationale |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design review of Interface/App relationship and PageType duplicates. Conclusion: don't merge InterfaceSchema into AppSchema (navigation container ≠ content surface), don't merge overlapping page types (distinct abstraction levels). Instead, bridge and clarify.
InterfaceNavItemSchema (
app.zod.ts)App navigation had no way to reference Interfaces. Added
type: 'interface'nav item:PageTypeSchema disambiguation (
page.zod.ts)Added JSDoc clarifying the 3 overlap pairs that were flagged:
record(component-based FlexiPage layout) vsrecord_detail(auto-generated field display)home(platform-level landing) vsoverview(interface-level navigation hub)app/utility/blank— distinct layout contexts, not duplicatesDesign doc updates
Tests
5 new tests for
InterfaceNavItemSchema+ 1 real-world App↔Interface navigation test. 199 files, 5473 tests pass.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.