Skip to content

Move lint & typecheck to manual workflow_dispatch trigger#48

Merged
hotlong merged 2 commits intomainfrom
copilot/refactor-lint-typecheck-trigger
Feb 14, 2026
Merged

Move lint & typecheck to manual workflow_dispatch trigger#48
hotlong merged 2 commits intomainfrom
copilot/refactor-lint-typecheck-trigger

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 14, 2026

Lint and typecheck are non-essential CI steps that don't need to run on every push/PR. Move them to manual trigger to reduce CI noise and save runner minutes.

  • ci.yml: Remove Type Check (Mobile), Type Check (Docs), and Lint steps; retain only test + coverage upload on push/PR
  • lint-typecheck.yml (new): Standalone workflow_dispatch-only workflow with the same lint and typecheck steps
Original prompt

非必要的工作流改为手工触发 lint typecheck


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor lint and typecheck to manual trigger Move lint & typecheck to manual workflow_dispatch trigger Feb 14, 2026
Copilot AI requested a review from hotlong February 14, 2026 01:11
@hotlong hotlong marked this pull request as ready for review February 14, 2026 01:41
Copilot AI review requested due to automatic review settings February 14, 2026 01:41
@hotlong hotlong merged commit 264c342 into main Feb 14, 2026
2 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces automated CI workload by removing lint and TypeScript type-check steps from the default push/PR workflow and moving them into a separate manually triggered GitHub Actions workflow.

Changes:

  • Removed mobile typecheck, docs typecheck, and ESLint steps from the main CI workflow so it runs only Jest + coverage upload on push/PR.
  • Added a new workflow_dispatch-only workflow to run lint and both typecheck variants on demand.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/lint-typecheck.yml New manually triggered workflow to run TypeScript checks (mobile + docs) and ESLint.
.github/workflows/ci.yml Simplifies push/PR CI to only run Jest coverage and upload the coverage artifact.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
@@ -23,12 +23,6 @@ jobs:
node-version: 20
cache: pnpm
- run: pnpm install
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes lint + typecheck no longer run on push/PR, but the repo documentation still describes “Push / PR → Lint & Type Check” as part of the CI pipeline (e.g., docs/DEPLOYMENT.md). Please update the docs (and any PR checklist references to CI-enforced checks) to avoid contributors assuming these run automatically.

Suggested change
- run: pnpm install
- run: pnpm install
- name: Lint
run: pnpm lint
- name: Typecheck
run: pnpm typecheck

Copilot uses AI. Check for mistakes.
Comment thread .github/workflows/ci.yml
Comment on lines 26 to 27
- name: Test
run: npx jest --ci --coverage
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After removing the Type Check/Lint steps, this workflow’s only remaining CI signal is running Jest. Consider renaming the job/workflow labels (e.g., from “Code Quality” to “Tests”) so the check name reflects what it actually does and is easier to interpret in PR status checks.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants