Move lint & typecheck to manual workflow_dispatch trigger#48
Conversation
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR reduces automated CI workload by removing lint and TypeScript type-check steps from the default push/PR workflow and moving them into a separate manually triggered GitHub Actions workflow.
Changes:
- Removed mobile typecheck, docs typecheck, and ESLint steps from the main CI workflow so it runs only Jest + coverage upload on push/PR.
- Added a new
workflow_dispatch-only workflow to run lint and both typecheck variants on demand.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/lint-typecheck.yml |
New manually triggered workflow to run TypeScript checks (mobile + docs) and ESLint. |
.github/workflows/ci.yml |
Simplifies push/PR CI to only run Jest coverage and upload the coverage artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -23,12 +23,6 @@ jobs: | |||
| node-version: 20 | |||
| cache: pnpm | |||
| - run: pnpm install | |||
There was a problem hiding this comment.
This change makes lint + typecheck no longer run on push/PR, but the repo documentation still describes “Push / PR → Lint & Type Check” as part of the CI pipeline (e.g., docs/DEPLOYMENT.md). Please update the docs (and any PR checklist references to CI-enforced checks) to avoid contributors assuming these run automatically.
| - run: pnpm install | |
| - run: pnpm install | |
| - name: Lint | |
| run: pnpm lint | |
| - name: Typecheck | |
| run: pnpm typecheck |
| - name: Test | ||
| run: npx jest --ci --coverage |
There was a problem hiding this comment.
After removing the Type Check/Lint steps, this workflow’s only remaining CI signal is running Jest. Consider renaming the job/workflow labels (e.g., from “Code Quality” to “Tests”) so the check name reflects what it actually does and is easier to interpret in PR status checks.
Lint and typecheck are non-essential CI steps that don't need to run on every push/PR. Move them to manual trigger to reduce CI noise and save runner minutes.
ci.yml: RemoveType Check (Mobile),Type Check (Docs), andLintsteps; retain only test + coverage upload on push/PRlint-typecheck.yml(new): Standaloneworkflow_dispatch-only workflow with the same lint and typecheck stepsOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.