Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
hotlong
approved these changes
Jan 28, 2026
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update objectstack kernel to latest version and adjust code
Upgrade @objectstack/spec to v0.6.0
Jan 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Upgrades @objectstack/spec to v0.6.0 across the monorepo and adjusts docs/example plugin code to remain compatible with the newer spec.
Changes:
- Bumped
@objectstack/specdependency to0.6.0in root, kernel, and server packages. - Updated version references in documentation/comments from v0.4.1 to v0.6.0.
- Adjusted the example plugin to access a non-spec
schedulervia a type assertion.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates root dependency on @objectstack/spec to 0.6.0. |
| packages/kernel/package.json | Updates kernel dependency on @objectstack/spec to 0.6.0. |
| packages/server/package.json | Updates server dependency on @objectstack/spec to 0.6.0. |
| packages/kernel/src/plugins/example-spec-plugin.ts | Updates spec version references and changes scheduler access to avoid type errors with v0.6.0. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| if (context.app.scheduler) { | ||
| context.app.scheduler.schedule( | ||
| // Note: Scheduler is not part of the @objectstack/spec yet, but can be added by implementations | ||
| const appWithScheduler = context.app as any; |
There was a problem hiding this comment.
Using as any removes type safety and can hide real integration issues. Prefer a narrow local type (e.g., type AppWithScheduler = typeof context.app & { scheduler?: { schedule: (...args: any[]) => unknown } }) or a small type guard function so only the scheduler augmentation is loosened rather than the whole object.
Suggested change
| const appWithScheduler = context.app as any; | |
| type AppWithScheduler = typeof context.app & { | |
| scheduler?: { | |
| schedule: (...args: any[]) => unknown; | |
| }; | |
| }; | |
| const appWithScheduler = context.app as AppWithScheduler; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades
@objectstack/specfrom 0.3.3/0.4.1 to 0.6.0 across the monorepo to align with latest protocol specifications.Changes
@objectstack/specto 0.6.0 in root, kernel, and server packagesexample-spec-plugin.tsfor scheduler (not yet in spec):New in v0.6.0
The spec now includes
data-engine.zod- a standardized interface for data persistence engines (ObjectQL, Prisma, TypeORM, etc.) following the Dependency Inversion Principle. Available for future adoption but not required for this upgrade.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.