Skip to content

[WIP] Update CI pipeline configuration for better efficiency#156

Merged
xuyushun441-sys merged 3 commits intocopilot/refactor-kernel-and-serverfrom
copilot/update-ci-pipeline-configuration
Feb 1, 2026
Merged

[WIP] Update CI pipeline configuration for better efficiency#156
xuyushun441-sys merged 3 commits intocopilot/refactor-kernel-and-serverfrom
copilot/update-ci-pipeline-configuration

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 1, 2026

Fix TypeScript Compilation Errors in CI Build

Issues Found

The CI build is failing with multiple TypeScript compilation errors:

  1. Missing type declarations for pg and better-sqlite3 modules
  2. Missing type annotations in auth controller and middleware
  3. Type mismatch between @objectstack/runtime PluginContext and @objectstack/core PluginContext

Plan

  • Analyze the CI failure logs and understand the issues
  • Add missing TypeScript type packages for pg and better-sqlite3
  • Fix type annotations in auth.controller.ts (req and res parameters, error type)
  • Fix Express Request type extension in auth.middleware.ts (add proper type declaration for user property)
  • Fix PluginContext interface in @objectstack/runtime to match @objectstack/core (add getServices and getKernel methods)
  • Run build to verify all fixes work
  • Review and commit changes
Original prompt

引用: https://github.com/objectstack-ai/objectos/actions/runs/21559561213/job/62121356089#step:6:1


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@vercel
Copy link
Copy Markdown

vercel bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectos Error Error Feb 1, 2026 8:39am

Request Review

- Add @types/pg and @types/better-sqlite3 dev dependencies
- Fix type annotations in auth.controller.ts (Request, Response, error handling)
- Add Express type augmentation for user property on Request
- Update PluginContext interface to include getServices() and getKernel() methods
- Implement getKernel() in PluginContextImpl and set kernel reference

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
@xuyushun441-sys
Copy link
Copy Markdown
Contributor

@copilot 继续

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Feb 1, 2026

@copilot 继续

The TypeScript compilation errors have been fixed in commit 8fea154 and c8ee38b. The build and all tests are now passing locally.

The CI workflow is showing "action_required" status because it needs approval to run on this PR. Once approved, the CI should pass successfully with these fixes:

  1. ✅ Added @types/pg and @types/better-sqlite3 dependencies
  2. ✅ Fixed type annotations in auth controller and middleware
  3. ✅ Added Express type augmentation for user property
  4. ✅ Updated PluginContext interface to match @objectstack/core
  5. ✅ Build completes successfully
  6. ✅ All tests pass (21 runtime tests, 37 audit-log tests, 7 better-auth tests)

Copilot AI requested a review from xuyushun441-sys February 1, 2026 08:47
@xuyushun441-sys xuyushun441-sys marked this pull request as ready for review February 1, 2026 08:52
@xuyushun441-sys xuyushun441-sys merged commit a9ae8d3 into copilot/refactor-kernel-and-server Feb 1, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants