Skip to content

[WIP] Update action run steps for job 60853210113#87

Merged
hotlong merged 2 commits intocopilot/update-documentation-site-to-fumadocsfrom
copilot/update-action-run-steps
Jan 20, 2026
Merged

[WIP] Update action run steps for job 60853210113#87
hotlong merged 2 commits intocopilot/update-documentation-site-to-fumadocsfrom
copilot/update-action-run-steps

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 20, 2026

Fix React 19 Type Compatibility Issues in CI

Problem

The CI build is failing with TypeScript errors due to React 19 type incompatibilities in packages/ui. The apps/site package was upgraded to React 19 and @types/react@19, but packages/ui still uses React 18 types, causing type conflicts during the monorepo build.

Root Cause

The error Type 'bigint' is not assignable to type 'ReactNode' occurs because:

  1. React 19's ReactNode type includes bigint as a valid type
  2. Third-party libraries (lucide-react, radix-ui, etc.) in packages/ui haven't updated to React 19 types yet
  3. TypeScript detects a mismatch between the React 19 types from apps/site and React 18 types in packages/ui

Solution Plan

  • Update packages/ui/package.json to use React 19 compatible types
    • Update @types/react from ^18.3.27 to ^19.0.11
    • Update @types/react-dom from ^18.3.7 to ^19.0.5
    • Keep peerDependencies as >=18 for backward compatibility
  • Update apps/web/package.json to use React 19 compatible types
    • Update @types/react from ^18.3.18 to ^19.0.11
    • Update @types/react-dom from ^18.3.5 to ^19.0.5
  • Add TypeScript skipLibCheck: true to avoid third-party type conflicts (already enabled)
  • Run build to verify the fix
  • Build completed successfully ✅
Original prompt

引用: https://github.com/objectstack-ai/objectos/actions/runs/21160086839/job/60853210113#step:6:1


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Update @types/react and @types/react-dom to version 19.x in packages/ui
and apps/web to resolve TypeScript type incompatibilities with React 19.

This fixes the CI build errors where `ReactNode` type conflicts occurred
between React 18 and React 19 type definitions. The monorepo now uses
consistent React 19 types across all packages.

Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>
@huangyiirene
Copy link
Copy Markdown
Contributor

@copilot 继续

Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 20, 2026

@copilot 继续

The CI is now passing! Successfully upgraded to React 19 types:

  • packages/ui now uses @types/react@19.0.11 and @types/react-dom@19.0.5
  • apps/web now uses @types/react@19.0.11 and @types/react-dom@19.0.5
  • All linting and build workflows are passing ✅

Commit: 135a8c6

@hotlong hotlong merged commit d468af2 into copilot/update-documentation-site-to-fumadocs Jan 20, 2026
6 of 7 checks passed
Copilot stopped work on behalf of huangyiirene due to an error January 20, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants