Remove npm package-lock.json from pnpm workspace package #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vscode-objectql package had its own package-lock.json which conflicted with the pnpm workspace setup. This caused the dependency review workflow to fail. Fix: Removed packages/tools/vscode-objectql/package-lock.json since the package is part of the pnpm workspace (defined in pnpm-workspace.yaml under packages/tools/*) and should use the root pnpm-lock.yaml instead. Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with problematic package
Remove npm package-lock.json from pnpm workspace package
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vscode-objectql package contained a
package-lock.jsonwhile being part of the pnpm workspace (packages/tools/*inpnpm-workspace.yaml), causing dependency review failures due to conflicting package manager metadata.Changes
packages/tools/vscode-objectql/package-lock.jsonpnpm-lock.yamlexclusivelyThe dependency review action was scanning both lock files with different resolution algorithms, triggering false positives. All workspace packages must use pnpm for consistent dependency management.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.