fix: Make FieldConfig.name and FieldConfig.label optional#136
Merged
huangyiirene merged 2 commits intocopilot/refactor-objectql-adherencefrom Jan 19, 2026
Merged
Conversation
…mpilation errors The @objectstack/spec package requires name and label fields on the Field type, but when fields are defined in ObjectConfig.fields as a Record<string, FieldConfig>, the name is inferred from the record key. This change makes name and label optional in FieldConfig to match this usage pattern. Co-authored-by: huangyiirene <7665279+huangyiirene@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue in step 10 of workflow
fix: Make FieldConfig.name and FieldConfig.label optional
Jan 18, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing with TypeScript errors:
Type '{ type: "text" }' is missing the following properties from type 'FieldConfig': name, label. The@objectstack/specpackage requires these fields onField, whichFieldConfigextends.Context
When fields are defined inline in
ObjectConfig.fields, the field name is derived from the Record key:The runtime already handles this at
packages/foundation/core/src/object.ts:15-17:Changes
packages/foundation/types/src/field.ts'name' | 'label'to theOmittype inFieldConfigThis aligns the type definition with the runtime behavior where these properties are inferred from context.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fastdl.mongodb.org/usr/local/bin/node /usr/local/bin/node /home/REDACTED/work/objectql/objectql/node_modules/.pnpm/jest-worker@30.2.0/node_modules/jest-worker/build/processChild.js(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.