Fix pagination metadata and bulk operations in server tests#184
Merged
hotlong merged 3 commits intocopilot/release-new-versionfrom Jan 24, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
- Fixed pagination metadata calculation to exclude limit/skip from count - Fixed MockDriver to support QueryAST 'top' field instead of 'limit' - Fixed MockDriver to handle FilterNode array format from QueryAST - Fixed count method to exclude skip/limit parameters - All 129 tests now passing Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
- Added JSDoc comments to matchesFilter and evaluateCondition methods - Fixed 'in' operator to return false when value is not an array - All tests still passing Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update documentation links in project
Fix pagination metadata and bulk operations in server tests
Jan 24, 2026
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four server tests were failing due to incorrect pagination count calculation and MockDriver-QueryAST format mismatches.
Changes
packages/runtime/server/src/server.tsfiltersandexpandbefore callingcount()to exclude pagination parameters from total count calculationpackages/runtime/server/test/rest.test.tstopfield (previously only checkedlimit)[['field', 'op', 'value']]from FilterTranslatorpackages/runtime/server/test/rest-advanced.test.tstopfieldContext
The QueryBuilder converts
{ limit: 10, filters: { role: 'user' } }into QueryAST with{ top: 10, filters: [['role', '=', 'user']] }. MockDrivers were expecting the unconverted format, causing:Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fonts.googleapis.com/usr/local/bin/node node /home/REDACTED/work/objectql/objectql/apps/site/node_modules/.bin/../next/dist/bin/next build(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.