[WIP] Update references for actions run in project #253
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
- Add plugin-validator and plugin-formula to root tsconfig references - Update core package tsconfig to reference plugin packages - Fix CLI import to use plugin-validator directly - Add plugin-validator dependency to CLI package Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
github-actions
bot
added
🔧 tooling
🏗️ foundation
📦 dependencies
⚙️ configuration
size/S
labels
|
There was a problem hiding this comment.
Pull request overview
Updates workspace/project references and package imports to address CI/TypeScript build issues after the lockfile upgrade, specifically around the validator/formula plugins being separate packages.
Changes:
- Adds TypeScript project references for
plugin-validatorandplugin-formulaat the repo root and within@objectql/core. - Updates the CLI AI command to import
Validatorfrom@objectql/plugin-validatorinstead of@objectql/core. - Adds
@objectql/plugin-validatoras a CLI dependency and TS project reference.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Includes plugin packages in the solution build graph. |
| packages/tools/cli/tsconfig.json | Ensures CLI builds against the validator plugin project. |
| packages/tools/cli/src/commands/ai.ts | Switches Validator import to @objectql/plugin-validator. |
| packages/tools/cli/package.json | Adds runtime dependency on @objectql/plugin-validator. |
| packages/foundation/core/tsconfig.json | Ensures @objectql/core builds after the referenced plugin projects. |
Comments suppressed due to low confidence (1)
packages/tools/cli/src/commands/ai.ts:395
- Unused variable validator.
const validator = new Validator({ language: 'en' });
| import OpenAI from 'openai'; | ||
| import { Validator, ObjectQLAgent } from '@objectql/core'; | ||
| import { ObjectQLAgent } from '@objectql/core'; | ||
| import { Validator } from '@objectql/plugin-validator'; |
There was a problem hiding this comment.
This updates the CLI to import Validator from @objectql/plugin-validator, but there is still at least one repo import that uses Validator from @objectql/core (e.g. packages/foundation/platform-node/test/validation.test.ts). With the current @objectql/core exports, that import will fail and break the Jest project tests. Update the remaining import(s) to @objectql/plugin-validator and add the dependency in the consuming package as needed.
| import { Validator } from '@objectql/plugin-validator'; |
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.