Skip to content

Fix version assertions in protocol plugin tests#288

Merged
hotlong merged 2 commits into
mainfrom
copilot/fix-issue-in-action-run-step
Feb 1, 2026
Merged

Fix version assertions in protocol plugin tests#288
hotlong merged 2 commits into
mainfrom
copilot/fix-issue-in-action-run-step

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 1, 2026

CI was failing because test assertions expected version 0.1.0 while plugin implementations declare 0.2.0.

Changes

  • Updated version expectations in @objectql/protocol-odata-v4 test from 0.1.00.2.0
  • Updated version expectations in @objectql/protocol-json-rpc test from 0.1.00.2.0

Both plugins were updated to version 0.2.0 in their implementations but test assertions were not synchronized.

Original prompt

引用: https://github.com/objectstack-ai/objectql/actions/runs/21555087304/job/62109904774#step:9:1


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectql Ready Ready Preview, Comment Feb 1, 2026 2:53am

Request Review

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix issue in action run step of workflow Fix version assertions in protocol plugin tests Feb 1, 2026
Copilot AI requested a review from hotlong February 1, 2026 02:49
@hotlong hotlong marked this pull request as ready for review February 1, 2026 02:54
Copilot AI review requested due to automatic review settings February 1, 2026 02:54
@hotlong hotlong merged commit 5b975d3 into main Feb 1, 2026
3 checks passed
@hotlong hotlong deleted the copilot/fix-issue-in-action-run-step branch February 1, 2026 02:54
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes failing CI tests by synchronizing version assertions in protocol plugin tests with the actual plugin implementation versions. The plugins were updated to version 0.2.0 in their implementations, but the test expectations were still checking for the old 0.1.0 version.

Changes:

  • Updated version assertion in @objectql/protocol-odata-v4 test from 0.1.0 to 0.2.0
  • Updated version assertion in @objectql/protocol-json-rpc test from 0.1.0 to 0.2.0

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/protocols/odata-v4/src/index.test.ts Updated version expectation to match the plugin's actual version (0.2.0)
packages/protocols/json-rpc/src/index.test.ts Updated version expectation to match the plugin's actual version (0.2.0)
Comments suppressed due to low confidence (1)

packages/protocols/json-rpc/src/index.test.ts:7

  • Unused import vi.
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants