Fix version assertions in protocol plugin tests#288
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue in action run step of workflow
Fix version assertions in protocol plugin tests
Feb 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes failing CI tests by synchronizing version assertions in protocol plugin tests with the actual plugin implementation versions. The plugins were updated to version 0.2.0 in their implementations, but the test expectations were still checking for the old 0.1.0 version.
Changes:
- Updated version assertion in
@objectql/protocol-odata-v4test from0.1.0to0.2.0 - Updated version assertion in
@objectql/protocol-json-rpctest from0.1.0to0.2.0
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/protocols/odata-v4/src/index.test.ts | Updated version expectation to match the plugin's actual version (0.2.0) |
| packages/protocols/json-rpc/src/index.test.ts | Updated version expectation to match the plugin's actual version (0.2.0) |
Comments suppressed due to low confidence (1)
packages/protocols/json-rpc/src/index.test.ts:7
- Unused import vi.
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI was failing because test assertions expected version
0.1.0while plugin implementations declare0.2.0.Changes
@objectql/protocol-odata-v4test from0.1.0→0.2.0@objectql/protocol-json-rpctest from0.1.0→0.2.0Both plugins were updated to version
0.2.0in their implementations but test assertions were not synchronized.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.