Skip to content

Fix missing devDependency for protocol integration tests#290

Merged
hotlong merged 3 commits intomainfrom
copilot/update-action-workflow-step
Feb 1, 2026
Merged

Fix missing devDependency for protocol integration tests#290
hotlong merged 3 commits intomainfrom
copilot/update-action-workflow-step

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 1, 2026

Protocol integration tests import @objectql/driver-memory to mock the kernel, but the dependency was not declared in devDependencies, causing Vitest module resolution failures in CI.

Changes

  • Added @objectql/driver-memory to devDependencies in:
    • packages/protocols/odata-v4/package.json
    • packages/protocols/graphql/package.json
    • packages/protocols/json-rpc/package.json

All three packages follow the same pattern in their integration tests:

import { MemoryDriver } from '@objectql/driver-memory';

const createTestKernel = () => {
    const driver = new MemoryDriver();
    // ... test setup
};

The dependency was previously missing, causing:

Error: Failed to load url @objectql/driver-memory (resolved id: @objectql/driver-memory)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • fonts.googleapis.com
    • Triggering command: /usr/local/bin/node node /home/REDACTED/work/objectql/objectql/apps/site/node_modules/.bin/../next/dist/bin/next build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

引用: https://github.com/objectstack-ai/objectql/actions/runs/21557564081/job/62116479038#step:9:1


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 1, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectql Ready Ready Preview, Comment Feb 1, 2026 6:04am

Request Review

…otocol

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
…ation tests

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Update action workflow step for better clarity Fix missing devDependency for protocol integration tests Feb 1, 2026
Copilot AI requested a review from hotlong February 1, 2026 06:06
@hotlong hotlong marked this pull request as ready for review February 1, 2026 06:11
Copilot AI review requested due to automatic review settings February 1, 2026 06:11
@hotlong hotlong merged commit 2cc4e06 into main Feb 1, 2026
3 checks passed
@hotlong hotlong deleted the copilot/update-action-workflow-step branch February 1, 2026 06:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR declares the missing @objectql/driver-memory devDependency for the protocol packages so their Vitest integration tests can resolve and run correctly, especially in CI.

Changes:

  • Added @objectql/driver-memory as a devDependency to packages/protocols/odata-v4, packages/protocols/graphql, and packages/protocols/json-rpc.
  • Updated pnpm-lock.yaml to lock the new workspace links for @objectql/driver-memory under each of the three protocol package importers.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
pnpm-lock.yaml Adds @objectql/driver-memory workspace links under the devDependencies for the three protocol packages, keeping the lockfile consistent with package manifests.
packages/protocols/odata-v4/package.json Declares @objectql/driver-memory as a devDependency so the OData V4 integration tests can import MemoryDriver.
packages/protocols/json-rpc/package.json Declares @objectql/driver-memory as a devDependency so the JSON-RPC integration tests can import MemoryDriver.
packages/protocols/graphql/package.json Declares @objectql/driver-memory as a devDependency so the GraphQL integration tests can import MemoryDriver.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants