Fix missing devDependency for protocol integration tests#290
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…otocol Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
…ation tests Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update action workflow step for better clarity
Fix missing devDependency for protocol integration tests
Feb 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR declares the missing @objectql/driver-memory devDependency for the protocol packages so their Vitest integration tests can resolve and run correctly, especially in CI.
Changes:
- Added
@objectql/driver-memoryas adevDependencytopackages/protocols/odata-v4,packages/protocols/graphql, andpackages/protocols/json-rpc. - Updated
pnpm-lock.yamlto lock the new workspace links for@objectql/driver-memoryunder each of the three protocol package importers.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds @objectql/driver-memory workspace links under the devDependencies for the three protocol packages, keeping the lockfile consistent with package manifests. |
| packages/protocols/odata-v4/package.json | Declares @objectql/driver-memory as a devDependency so the OData V4 integration tests can import MemoryDriver. |
| packages/protocols/json-rpc/package.json | Declares @objectql/driver-memory as a devDependency so the JSON-RPC integration tests can import MemoryDriver. |
| packages/protocols/graphql/package.json | Declares @objectql/driver-memory as a devDependency so the GraphQL integration tests can import MemoryDriver. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Protocol integration tests import
@objectql/driver-memoryto mock the kernel, but the dependency was not declared indevDependencies, causing Vitest module resolution failures in CI.Changes
@objectql/driver-memoryto devDependencies in:packages/protocols/odata-v4/package.jsonpackages/protocols/graphql/package.jsonpackages/protocols/json-rpc/package.jsonAll three packages follow the same pattern in their integration tests:
The dependency was previously missing, causing:
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
fonts.googleapis.com/usr/local/bin/node node /home/REDACTED/work/objectql/objectql/apps/site/node_modules/.bin/../next/dist/bin/next build(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.