Fix SQL driver TCK tests: use sqlite3 instead of better-sqlite3#308
Merged
hotlong merged 2 commits intoFeb 2, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…able initialization Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix action step error in GitHub workflows
Fix SQL driver TCK tests: use sqlite3 instead of better-sqlite3
Feb 2, 2026
Contributor
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes the SQL driver TCK test suite which was completely failing due to a missing dependency reference. The fix changes the SQLite client from better-sqlite3 (not installed) to sqlite3 (already in devDependencies), adds proper table initialization via driver.init(), and ensures clean connection teardown.
Changes:
- Changed SQLite client from
better-sqlite3tosqlite3for consistency with other test files and available dependencies - Replaced manual table-dropping logic with
driver.init()call to create thetck_testtable with proper schema - Added connection cleanup in
afterEachto prevent resource leaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SQL driver TCK test suite was failing with "Cannot find module 'better-sqlite3'" because it referenced an uninstalled dependency. All other SQL driver tests use
sqlite3(already in devDependencies), buttck.test.tswas an outlier.Changes
better-sqlite3tosqlite3for consistency with other test filesdriver.init()call inbeforeEachhook to create thetck_testtable that TCK tests expectdriver['knex'].destroy()inafterEachto prevent connection leaksImpact
Before: 34/34 TCK tests failed (module not found)
After: 26/34 TCK tests pass
The remaining 8 failures are pre-existing driver implementation gaps (
findOnereturnsundefinedvsnull, bulk operation metadata, etc.) unrelated to this fix.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.