Skip to content

fix: add --passWithNoTests to driver-utils test script #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Feb 2, 2026
Merged

fix: add --passWithNoTests to driver-utils test script #312

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44e3c92
Initial plan
Copilot Feb 2, 2026
1341415
fix: add --passWithNoTests flag to driver-utils test script
Copilot Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/drivers/utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"types": "dist/index.d.ts",
"scripts": {
"build": "tsc",
"test": "jest"
"test": "jest --passWithNoTests"
Copy link

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this fix is correct for the immediate CI issue, there's an inconsistency across the monorepo. Several other packages also have no test files but use "test": "jest" without the --passWithNoTests flag (e.g., @objectql/driver-sql, @objectql/driver-memory, @objectql/core, @objectql/plugin-validator). These packages would also fail CI if their test scripts are executed.

Consider either:

  1. Adding --passWithNoTests to all packages without tests for consistency
  2. Or adding placeholder test files to maintain the ability to detect when test execution genuinely fails

The current approach creates an inconsistent testing configuration across the monorepo.

Copilot uses AI. Check for mistakes.
},
"keywords": [
"objectql",
Expand Down