Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
… meets all refactoring prerequisites Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Evaluate current code against refactor requirements
docs: evaluate upstream @objectstack/spec compliance, update DESIGN_CORE_REFACTOR.md
Feb 11, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the core refactor design doc to reflect that previously identified upstream @objectstack/spec prerequisites have been implemented, promoting the plan from “Draft / RFC” to “Ready for Implementation”.
Changes:
- Updated document header/status and pinned the upstream verification commit (
33646a7). - Reworked §5 to mark upstream prerequisites as complete, adding concrete evidence/links and removing now-obsolete proposed changes.
- Added an “Upstream Compliance Verification” appendix detailing verified exports and
PluginContextsurface expectations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluated upstream
@objectstack/spec(commit33646a7) against the refactoring prerequisites inDESIGN_CORE_REFACTOR.md. All upstream blockers are resolved — the document status moves from "Draft / RFC" to "Ready for Implementation".Upstream findings
OperationContext&EngineMiddlewaretypes (PR-1, 🔴 blocking)packages/objectql/src/index.ts, PR #597replaceService<T>()onPluginContext(PR-2, 🟡 medium)types.ts,kernel.ts,kernel-base.ts,plugin-loader.ts— commitb6b411eObjectQL.registerMiddleware()onion model@objectstack/spec/contracts(PRs #599, #600)Document updates
Ready for Implementation, addedUpdateddate, pinned upstream commit refEngineMiddleware,replaceServicePluginContextAPI surface, engine middleware verification💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.