Skip to content

fix: register ObjectQLSecurityPlugin as 'security' service, not 'auth' #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Mar 20, 2026
Merged

fix: register ObjectQLSecurityPlugin as 'security' service, not 'auth' #419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9f0e66
Initial plan
Copilot Mar 20, 2026
40df750
fix: register ObjectQLSecurityPlugin as 'security' service instead of…
Copilot Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ROADMAP.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -968,7 +968,7 @@ Standardize third-party plugin distribution.
| `packages/foundation/plugin-query` | `@objectql/plugin-query` | Universal | QueryService, QueryBuilder, QueryAnalyzer, FilterTranslator. |
| `packages/foundation/plugin-optimizations` | `@objectql/plugin-optimizations` | Universal | Connection pooling, query compilation, compiled hooks, lazy metadata. |
| `packages/foundation/platform-node` | `@objectql/platform-node` | Node.js | File system integration, YAML loading, glob-based plugin discovery. |
| `packages/foundation/plugin-security` | `@objectql/plugin-security` | Universal | RBAC, FLS, RLS with AST-level enforcement. |
| `packages/foundation/plugin-security` | `@objectql/plugin-security` | Universal | RBAC, FLS, RLS with AST-level enforcement. Registers as `'security'` service (not `'auth'`; `'auth'` is reserved for `@objectstack/plugin-auth`). |
| `packages/foundation/plugin-validator` | `@objectql/plugin-validator` | Universal | 5-type validation engine. |
| `packages/foundation/plugin-formula` | `@objectql/plugin-formula` | Universal | Computed fields with sandboxed JS expressions. |
| `packages/foundation/plugin-workflow` | `@objectql/plugin-workflow` | Universal | State machine executor with guards, actions, compound states. |
Expand Down
4 changes: 2 additions & 2 deletions packages/foundation/plugin-security/__tests__/plugin.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ describe('ObjectQLSecurityPlugin', () => {
expect(kernel.use).not.toHaveBeenCalled();
});

it('should register auth service when registerService is available', async () => {
it('should register security service when registerService is available', async () => {
const plugin = new ObjectQLSecurityPlugin({
permissions: [ACCOUNTS_PERM],
});
Expand All @@ -122,7 +122,7 @@ describe('ObjectQLSecurityPlugin', () => {

await plugin.install({ engine: kernel, registerService });

expect(registerService).toHaveBeenCalledWith('auth', expect.anything());
expect(registerService).toHaveBeenCalledWith('security', expect.anything());
});

it('should not register hooks when RLS/FLS are disabled', async () => {
Expand Down
10 changes: 6 additions & 4 deletions packages/foundation/plugin-security/src/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,11 +147,13 @@ export class ObjectQLSecurityPlugin implements RuntimePlugin {
// Register security hooks
this.registerSecurityHooks(kernel, ctx);

// Register 'auth' service alias if available in context
// This allows ApiRegistry and other components to find the security service
// Register 'security' service alias if available in context
// This allows ApiRegistry and other components to find the security service.
// NOTE: We register as 'security' (authorization/RBAC), NOT 'auth'.
// The 'auth' service is reserved for @objectstack/plugin-auth (authentication).
if (typeof (ctx as any).registerService === 'function') {
(ctx as any).registerService('auth', kernel.security);
this.logger.info("Registered 'auth' service alias");
(ctx as any).registerService('security', kernel.security);
this.logger.info("Registered 'security' service alias");
Copy link

Copilot AI Mar 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String quotes are inconsistent here: this logger call uses double quotes while the rest of the file predominantly uses single quotes. For consistency (and to satisfy typical lint rules), switch this string literal to single quotes.

Suggested change
this.logger.info("Registered 'security' service alias");
this.logger.info('Registered \'security\' service alias');

Copilot uses AI. Check for mistakes.
}

this.logger.info('Security plugin installed successfully');
Expand Down
Loading