Remove unnecessary CI tests to reduce test suite overhead#1014
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unnecessary tests to reduce CI time
Remove unnecessary CI tests to reduce test suite overhead
Mar 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces CI runtime by removing low-signal / high-overhead Vitest test files that primarily performed export-existence checks, static-markup audits, or brittle source-regex assertions rather than exercising meaningful runtime behavior.
Changes:
- Removed multiple “registration/export exists” tests across plugins/components that largely duplicated build/type-check guarantees or are covered by other integration-style tests.
- Removed console tests that validated static HTML accessibility and source-file regex “performance” heuristics rather than actual rendered components/production bundles.
- Removed console schema/type “self-validation” style tests that asserted properties of objects created within the same test.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/plugin-view/src/tests/registration.test.tsx | Removed export existence checks for plugin-view entrypoints. |
| packages/plugin-list/src/registration.test.tsx | Removed trivial export existence check for ListView. |
| packages/plugin-detail/src/registration.test.tsx | Removed registry-metadata assertion test that depended on side-effect imports. |
| packages/plugin-charts/src/registration.test.tsx | Removed redundant registry existence tests (plugin-charts has deeper registry tests elsewhere). |
| packages/components/src/tests/Registry.test.ts | Removed registry smoke tests that overlap with other renderer/registration test suites. |
| apps/console/src/tests/console-load-performance.test.tsx | Removed brittle “read TSX as string + regex” and JSDOM timing heuristic tests. |
| apps/console/src/tests/console-accessibility.test.tsx | Removed axe-core tests against hand-written markup (not real component assemblies). |
| apps/console/src/tests/SpecCompliance.test.tsx | Removed runtime type/shape checks for typed config objects (largely redundant with TS/Zod validation paths). |
| apps/console/src/tests/SkeletonComponents.test.tsx | Removed low-signal skeleton smoke tests. |
| apps/console/src/tests/ServerDefinitions.test.tsx | Removed self-validating schema-definition tests with limited regression value. |
| apps/console/src/tests/ConsoleFeatures.test.tsx | Removed a single-feature console ObjectView smoke test (superseded by other ObjectView coverage). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each of the 384 test files incurs ~4.7s of setup overhead (environment init, imports, setup files). Removing files with no meaningful regression value directly reduces wall-clock time.
Removed 11 test files (~77 tests) across these categories:
SpecCompliance.test.tsx(24 tests checkingtypeof x === 'string'on typed config objects)ServerDefinitions.test.tsx(12 tests constructing schema objects then asserting their own properties)console-accessibility.test.tsx(10 axe-core tests on hand-written markup, not actual components — won't catch real regressions)console-load-performance.test.tsx(14 tests reading.tsxfiles as strings and regex-matching patterns)SkeletonComponents.test.tsx(only assertselement count > 0),ConsoleFeatures.test.tsx(1 test, superseded byObjectView.test.tsx)registration.test.tsxfiles in plugin-list, plugin-detail, plugin-view, plugin-charts, andRegistry.test.tsin components (collectively 10 tests that only calltoBeDefined()/typeof === 'function')Coverage thresholds should remain unaffected — removed tests covered no meaningful code paths.
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.