Skip to content

Remove unnecessary CI tests to reduce test suite overhead#1014

Merged
hotlong merged 2 commits intomainfrom
copilot/remove-unnecessary-ci-tests
Mar 3, 2026
Merged

Remove unnecessary CI tests to reduce test suite overhead#1014
hotlong merged 2 commits intomainfrom
copilot/remove-unnecessary-ci-tests

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 3, 2026

Each of the 384 test files incurs ~4.7s of setup overhead (environment init, imports, setup files). Removing files with no meaningful regression value directly reduces wall-clock time.

Removed 11 test files (~77 tests) across these categories:

  • Runtime type-checking tests redundant with TypeScript/ZodSpecCompliance.test.tsx (24 tests checking typeof x === 'string' on typed config objects)
  • Circular/self-validating testsServerDefinitions.test.tsx (12 tests constructing schema objects then asserting their own properties)
  • Static HTML accessibility testsconsole-accessibility.test.tsx (10 axe-core tests on hand-written markup, not actual components — won't catch real regressions)
  • Brittle source-file regex testsconsole-load-performance.test.tsx (14 tests reading .tsx files as strings and regex-matching patterns)
  • Trivial smoke testsSkeletonComponents.test.tsx (only asserts element count > 0), ConsoleFeatures.test.tsx (1 test, superseded by ObjectView.test.tsx)
  • Pure export existence checksregistration.test.tsx files in plugin-list, plugin-detail, plugin-view, plugin-charts, and Registry.test.ts in components (collectively 10 tests that only call toBeDefined() / typeof === 'function')

Coverage thresholds should remain unaffected — removed tests covered no meaningful code paths.

Original prompt

ci test 时间太长,请耐心的仔细评估每一个测试移除不必要的测试


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectui Ready Ready Preview, Comment Mar 3, 2026 3:07pm
objectui-demo Ready Ready Preview, Comment Mar 3, 2026 3:07pm
objectui-storybook Ready Ready Preview, Comment Mar 3, 2026 3:07pm

Request Review

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove unnecessary tests to reduce CI time Remove unnecessary CI tests to reduce test suite overhead Mar 3, 2026
@hotlong hotlong marked this pull request as ready for review March 3, 2026 15:26
Copilot AI review requested due to automatic review settings March 3, 2026 15:26
@hotlong hotlong merged commit ad18147 into main Mar 3, 2026
5 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reduces CI runtime by removing low-signal / high-overhead Vitest test files that primarily performed export-existence checks, static-markup audits, or brittle source-regex assertions rather than exercising meaningful runtime behavior.

Changes:

  • Removed multiple “registration/export exists” tests across plugins/components that largely duplicated build/type-check guarantees or are covered by other integration-style tests.
  • Removed console tests that validated static HTML accessibility and source-file regex “performance” heuristics rather than actual rendered components/production bundles.
  • Removed console schema/type “self-validation” style tests that asserted properties of objects created within the same test.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/plugin-view/src/tests/registration.test.tsx Removed export existence checks for plugin-view entrypoints.
packages/plugin-list/src/registration.test.tsx Removed trivial export existence check for ListView.
packages/plugin-detail/src/registration.test.tsx Removed registry-metadata assertion test that depended on side-effect imports.
packages/plugin-charts/src/registration.test.tsx Removed redundant registry existence tests (plugin-charts has deeper registry tests elsewhere).
packages/components/src/tests/Registry.test.ts Removed registry smoke tests that overlap with other renderer/registration test suites.
apps/console/src/tests/console-load-performance.test.tsx Removed brittle “read TSX as string + regex” and JSDOM timing heuristic tests.
apps/console/src/tests/console-accessibility.test.tsx Removed axe-core tests against hand-written markup (not real component assemblies).
apps/console/src/tests/SpecCompliance.test.tsx Removed runtime type/shape checks for typed config objects (largely redundant with TS/Zod validation paths).
apps/console/src/tests/SkeletonComponents.test.tsx Removed low-signal skeleton smoke tests.
apps/console/src/tests/ServerDefinitions.test.tsx Removed self-validating schema-definition tests with limited regression value.
apps/console/src/tests/ConsoleFeatures.test.tsx Removed a single-feature console ObjectView smoke test (superseded by other ObjectView coverage).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants