fix(console): unused params in test mocks breaking tsc build#1101
Merged
fix(console): unused params in test mocks breaking tsc build#1101
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
…s (TS6133) Fix TypeScript noUnusedParameters errors in ListToolbarActions.test.tsx lines 34 and 38 where mock component props were declared but not used. Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/d01cb686-bd58-4299-91af-8240dabcdc4c
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/d01cb686-bd58-4299-91af-8240dabcdc4c
Copilot
AI
changed the title
[WIP] Fix all CI errors and ensure successful build and test
fix(console): unused params in test mocks breaking tsc build
Mar 21, 2026
github-actions
bot
added
documentation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a TypeScript build failure in apps/console caused by noUnusedParameters: true, by adjusting test mock component signatures so CI tsc no longer reports TS6133.
Changes:
- Renamed unused mock component parameters from
propsto_propsinListToolbarActions.test.tsxto satisfynoUnusedParameters. - Added a corresponding Unreleased changelog entry documenting the CI/build fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/console/src/tests/ListToolbarActions.test.tsx | Updates vi.mock component factories to avoid TS6133 by marking props intentionally unused. |
| CHANGELOG.md | Documents the CI build fix under [Unreleased] → Fixed. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noUnusedParameters: trueinapps/console/tsconfig.jsoncauses TS6133 on two mock component declarations inListToolbarActions.test.tsx, failing thetscstep in CI.props→_propsinObjectKanbanandObjectCalendarvi.mock factoriesOriginal prompt
⚡ Quickly spin up Copilot coding agent tasks from anywhere on your macOS or Windows machine with Raycast.