fix: correct aria-label assertion in ObjectView chatter panel test#1129
Merged
fix: correct aria-label assertion in ObjectView chatter panel test#1129
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
The test used getByLabelText('Show discussion') but the actual
aria-label rendered by RecordChatterPanel is 'Show Discussion (0)'
(from i18n default translation with count parameter).
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/e52cb32e-6402-44bb-876a-f0658356524a
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com> Agent-Logs-Url: https://github.com/objectstack-ai/objectui/sessions/e52cb32e-6402-44bb-876a-f0658356524a
Copilot
AI
changed the title
[WIP] Fix all CI build and test errors
fix: correct aria-label assertion in ObjectView chatter panel test
Mar 26, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a CI test failure in the console’s ObjectView test suite by aligning the test query with the actual accessible label produced by RecordChatterPanel’s default i18n translation (which includes a count).
Changes:
- Update
ObjectView.test.tsxto query the correctaria-labelfor the collapsed discussion button (Show Discussion (0)). - Add a corresponding “Fixed” entry to
CHANGELOG.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/console/src/tests/ObjectView.test.tsx | Corrects the getByLabelText query to match RecordChatterPanel’s translated aria-label including count. |
| CHANGELOG.md | Documents the CI test fix under “Unreleased → Fixed”. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI test failure in
ObjectView.test.tsx— the RecordChatterPanel drawer test queried for a non-existent aria-label.getByLabelText('Show discussion')butRecordChatterPanelrendersaria-label={t('detail.showDiscussion', { count: items.length })}which resolves to'Show Discussion (0)'via default translations (capital D, includes count).page.goto: Timeout 60000ms exceeded— CI infrastructure timeouts, not code issues.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.