Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 19, 2026

CI failed because @object-ui/types imports from @objectstack/spec, but @objectstack/spec was never built before the test suite ran.

// packages/types/src/base.ts
import type { UIComponent } from '@objectstack/spec';  // ← Module not found

Changes

  • package.json: Added @objectstack/spec build step to pretest script before @object-ui/types
  • packages/objectstack-spec/package.json: Changed build command from tsc to tsc --build (required for composite TypeScript projects)
  • packages/objectstack-spec/tsconfig.json: Added moduleResolution: "node" override (root uses bundler mode which doesn't emit library artifacts)

Technical Context

TypeScript composite projects require tsc --build to emit output. The root tsconfig uses moduleResolution: "bundler" for app development, but library packages need "node" to generate proper declaration files.

Original prompt

引用: https://github.com/objectstack-ai/objectui/actions/runs/21130492398/job/60761808508#step:8:1


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@vercel
Copy link

vercel bot commented Jan 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
objectui-docs Error Error Jan 19, 2026 0:49am

- Add @objectstack/spec build to pretest script before @object-ui/types
- Fix @objectstack/spec build script to use 'tsc --build' for composite project
- Add moduleResolution: "node" to @objectstack/spec tsconfig for proper library build

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CI pipeline error in workflow Fix CI build failure: missing @objectstack/spec in build dependency chain Jan 19, 2026
Copilot AI requested a review from hotlong January 19, 2026 12:52
@github-actions
Copy link

✅ All checks passed!

  • ✅ Type check passed
  • ✅ Tests passed
  • ✅ Lint check completed

@huangyiirene huangyiirene marked this pull request as ready for review January 19, 2026 13:03
@huangyiirene huangyiirene merged commit 2d9bc45 into copilot/update-types-data-display Jan 19, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants