Skip to content

fix: enable mock server for E2E tests to fix sidebar rendering failures #1221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 1 commit into from
Apr 13, 2026
Merged

fix: enable mock server for E2E tests to fix sidebar rendering failures #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,9 @@ jobs:
run: pnpm install --frozen-lockfile

- name: Build Core & Console
run: pnpm turbo run build --filter='./packages/*' --filter='./apps/console'
run: |
pnpm turbo run build --filter='./packages/*'
pnpm --filter @object-ui/console build:e2e
Comment on lines 89 to +92
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The console build is now executed outside Turbo (pnpm --filter @object-ui/console build:e2e), which means Turbo caching won’t apply to that portion of the build. If CI build time becomes an issue, consider adding VITE_USE_MOCK_SERVER to Turbo’s tracked env (turbo.json globalEnv/task env) and running the console build via Turbo with the env set, so cache correctness and performance are both preserved.

Copilot uses AI. Check for mistakes.

- name: Check for build artifacts
run: |
Expand Down
1 change: 1 addition & 0 deletions apps/console/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
"start:mock": "pnpm msw:init && vite preview",
"build:plugin": "tsc -p tsconfig.plugin.json",
"build": "pnpm msw:init && tsc && VITE_USE_MOCK_SERVER=false vite build && pnpm build:plugin",
"build:e2e": "pnpm msw:init && tsc && VITE_USE_MOCK_SERVER=true vite build && pnpm build:plugin",
"build:vercel": "pnpm msw:init && tsc && VITE_USE_MOCK_SERVER=true vite build && pnpm build:plugin",
Comment on lines +28 to 29
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build:e2e is currently identical to build:vercel, which creates duplicated build logic and a risk of them drifting over time. Consider making one script call the other (or extracting a shared build:mock script) so there’s a single source of truth for the mock-enabled production build.

Suggested change
"build:e2e": "pnpm msw:init && tsc && VITE_USE_MOCK_SERVER=true vite build && pnpm build:plugin",
"build:vercel": "pnpm msw:init && tsc && VITE_USE_MOCK_SERVER=true vite build && pnpm build:plugin",
"build:mock": "pnpm msw:init && tsc && VITE_USE_MOCK_SERVER=true vite build && pnpm build:plugin",
"build:e2e": "pnpm build:mock",
"build:vercel": "pnpm build:mock",

Copilot uses AI. Check for mistakes.
"build:analyze": "pnpm build && echo 'Bundle analysis available at dist/stats.html'",
"preview": "vite preview",
Expand Down
Loading