Skip to content

fix: align NavigationItem and NavigationArea label types with @objectstack/spec v4 #1225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotlong merged 2 commits into from
Apr 14, 2026
Merged

fix: align NavigationItem and NavigationArea label types with @objectstack/spec v4 #1225

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c98944
chore: update pnpm lockfile to resolve dependency conflicts
Claude Apr 14, 2026
b4c18ee
fix: align NavigationItem and NavigationArea label types with @object…
Claude Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/types/src/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ export interface NavigationItem {
/** Navigation item type */
type: NavigationItemType;

/** Display label (plain string or I18nLabel object for internationalization) */
label: string | { key: string; defaultValue?: string; params?: Record<string, any> };
/** Display label (plain string per @objectstack/spec v4 protocol) */
label: string;

/** Icon name (Lucide) */
icon?: string;
Expand Down Expand Up @@ -129,8 +129,8 @@ export interface NavigationArea {
/** Unique identifier */
id: string;

/** Display label (plain string or I18nLabel object for internationalization) */
label: string | { key: string; defaultValue?: string; params?: Record<string, any> };
/** Display label (plain string per @objectstack/spec v4 protocol) */
label: string;

/** Icon name (Lucide) */
icon?: string;
Expand Down
Loading
Loading