feat(app-shell): plugin permission disclosure on install (ADR-0025 PD4)#1445
Merged
Merged
Conversation
Render a pre-install permission-disclosure panel for code-bearing
marketplace packages, consuming the cloud PD4 fields.
- marketplaceApi: extend MarketplacePackageVersion with the disclosure
fields the control plane now projects (artifact_kind, contains_code,
runtime, packaging, permissions, engines, signed, platform_verified).
- PluginDisclosure.tsx: a panel showing the "contains code" notice, the
trust tier, signed / reviewed-&-approved badges, and the exact
structured permission set ({ services, hooks, network, fs }) the plugin
asks to be granted — or "no special permissions".
- MarketplacePackagePage: show the panel in the install dialog and gate
the Install button behind an explicit "I understand" acknowledgement for
code packages (reset when the dialog closes).
Strings use t(..., { defaultValue }) so no translation-bundle change is
required to ship English.
Verified: app-shell tsc clean.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend for ADR-0025 PD4 — the pre-install permission-disclosure screen, consuming the cloud fields landed in objectstack-ai/cloud#32.
MarketplacePackageVersiongains the disclosure fields the control plane projects (artifact_kind,contains_code,runtime,packaging,permissions,engines,signed,platform_verified).signed/ "reviewed & approved" badges, and the exact{services, hooks, network, fs}the plugin requests (or "no special permissions").Strings use
t(..., { defaultValue }), so English ships without a translation-bundle change.Verified: app-shell
tscclean.After merge, cloud bumps
.objectui-shato pick this up.cloud-control-ux-wave2); this change is additive (new component + dialog section) but coordinate the merge to avoid clashing with that effort.🤖 Generated with Claude Code