Skip to content

refactor: unify runtime report editor onto studio's spec-driven inspector#1504

Merged
os-zhuang merged 3 commits into
mainfrom
claude/runtime-report-editor
Jun 6, 2026
Merged

refactor: unify runtime report editor onto studio's spec-driven inspector#1504
os-zhuang merged 3 commits into
mainfrom
claude/runtime-report-editor

Conversation

@os-zhuang
Copy link
Copy Markdown
Contributor

背景

延续 #1496(视图编辑统一到 studio):把运行时报表编辑也从 plugin-report 的旧 buildReportSchema + ConfigPanelRenderer 引擎,统一到 studio 的 spec 驱动 inspector。

报表的难点(与视图不同):ReportConfigPanelplugin-report 包,而 studio inspector 在 app-shell——app-shell 依赖 plugin-report,反向 import 会循环依赖。所以把编辑宿主搬进 app-shell。

改动(两阶段)

Stage 1 — studio 侧补齐报表 inspector

  • report-schema.ts:从 @objectstack/specReportSchema/reportForm 派生 JSONSchema + 授权表单(对标 view-schema.ts)。
  • ReportDefaultInspector.tsx:报表级 home inspector(label/object/type 选择 + 列管理 + spec 驱动 SchemaForm),对标 ViewVariantInspector;objectFieldsOverride 零网络。
  • 注册为 report 类型的 default inspector;EN/ZH i18n 各 16 键。

Stage 2 — 运行时迁移

  • 新增 app-shell 本地 ReportConfigPanel(drop-in 同签名),内部挂 ReportDefaultInspector;置于 app-shell 以避开循环依赖
  • ReportView 改用本地面板,不再 import plugin-report 的 ReportConfigPanel;availableFields 映射成 objectFieldsOverride。报表是扁平 ReportSchema,直接作为 draft,无需形状适配器
  • sys_report 持久化路径不变。plugin-report 的旧面板保留(其 JoinedBlocksEditor 仍内部引用)。

功能精简点(以 spec 表单为准)

  • 列的逐列属性编辑(label/aggregate)走 studio 的 scoped ReportColumnInspector,运行时未挂宿主,故运行时仅支持列的增/删/排序/选字段;旧面板的校验横幅也暂未呈现。已存数据原样保留。

验证

  • pnpm turbo run build --filter=@object-ui/app-shell:27/27 通过。
  • app-shell/src/views 测试 167 全过(含新增 report-schema 8 例 + ReportDefaultInspector 4 例)。
  • lint 改动文件 0 error。

https://claude.ai/code/session_01SZW3fVCCbijEibXtEH3ZGL


Generated by Claude Code

claude added 3 commits June 6, 2026 07:12
Add a curated report-level home inspector for the studio metadata editor,
mirroring ViewVariantInspector but for the flat Report document:

- report-schema.ts: derive the Report JSONSchema + authoring form from
  @objectstack/spec (ReportSchema / reportForm), pruning curated fields
- ReportDefaultInspector: label / object / type pickers + columns list
  (add / reorder / drill into the scoped ReportColumnInspector) + the
  spec-driven SchemaForm for the rest; network-free via objectFieldsOverride
- register as the default inspector for the 'report' type
- i18n keys (en + zh) for the report inspector labels

Studio-only; the runtime ReportView is migrated separately.
… inspector

ReportView's right-rail report editor now hosts the studio's spec-driven
ReportDefaultInspector instead of plugin-report's legacy
buildReportSchema/ConfigPanelRenderer panel, so runtime and studio share one
report-editing surface.

- new app-shell ReportConfigPanel (drop-in props) hosts ReportDefaultInspector;
  lives in app-shell to avoid a circular dep on plugin-report
- the flat Report document is the inspector draft directly (no shape adapter);
  availableFields are mapped to a network-free objectFieldsOverride
- ReportView no longer imports plugin-report's ReportConfigPanel; the
  sys_report persistence path is unchanged

plugin-report's panel is retained (still used internally by JoinedBlocksEditor).
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
objectui Ignored Ignored Jun 6, 2026 7:17am

Request Review

@github-actions github-actions Bot added the tests label Jun 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2026

✅ Console Performance Budget

Metric Value Budget
Main entry (gzip) 290.7 KB 350 KB
Entry file index-vLthaqUI.js
Status PASS

📦 Bundle Size Report

Package Size Gzipped
app-shell (index.js) 5.77KB 2.03KB
app-shell (runtime-config.js) 4.29KB 1.54KB
app-shell (types.js) 0.01KB 0.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 1.17KB 0.53KB
auth (AuthProvider.js) 17.16KB 3.44KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 4.79KB 1.88KB
auth (LoginForm.js) 5.11KB 1.92KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.63KB 2.15KB
auth (SocialSignInButtons.js) 8.89KB 3.61KB
auth (UserMenu.js) 3.40KB 1.22KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 22.29KB 5.30KB
auth (createAuthenticatedFetch.js) 3.33KB 1.32KB
auth (index.js) 1.75KB 0.76KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 4.01KB 0.79KB
auth (useIsWorkspaceAdmin.js) 1.28KB 0.70KB
collaboration (CommentThread.js) 18.38KB 4.49KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 3.65KB 1.42KB
collaboration (PresenceProvider.js) 2.42KB 0.96KB
collaboration (index.js) 1.25KB 0.53KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 397.93KB 84.13KB
core (index.js) 1.45KB 0.54KB
create-plugin (index.js) 9.28KB 2.98KB
data-objectstack (index.js) 90.43KB 22.43KB
fields (index.js) 144.92KB 34.19KB
i18n (i18n.js) 4.32KB 1.77KB
i18n (index.js) 2.27KB 0.91KB
i18n (provider.js) 5.37KB 1.72KB
i18n (useObjectLabel.js) 18.42KB 4.30KB
i18n (useSafeTranslation.js) 1.63KB 0.57KB
layout (index.js) 36.05KB 9.94KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.74KB
mobile (index.js) 1.50KB 0.62KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 4.42KB 1.27KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 2.53KB 0.85KB
mobile (useResponsive.js) 0.71KB 0.42KB
mobile (useResponsiveConfig.js) 1.36KB 0.63KB
mobile (useSpecGesture.js) 1.77KB 0.77KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 4.87KB 1.77KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 3.11KB 0.87KB
permissions (evaluator.js) 4.00KB 1.23KB
permissions (index.js) 0.91KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.52KB
permissions (usePermissions.js) 1.42KB 0.68KB
plugin-ai (index.js) 15.71KB 3.79KB
plugin-calendar (index.js) 45.98KB 12.65KB
plugin-charts (index.js) 39.09KB 11.07KB
plugin-chatbot (index.js) 115.56KB 28.13KB
plugin-dashboard (index.js) 87.61KB 20.96KB
plugin-designer (index.js) 213.42KB 42.94KB
plugin-detail (index.js) 192.46KB 46.34KB
plugin-editor (index.js) 2.38KB 1.06KB
plugin-form (index.js) 72.79KB 16.89KB
plugin-gantt (index.js) 28.30KB 7.76KB
plugin-grid (index.js) 110.04KB 29.58KB
plugin-kanban (index.js) 48.82KB 13.13KB
plugin-list (index.js) 89.76KB 21.04KB
plugin-map (index.js) 16.02KB 4.98KB
plugin-markdown (index.js) 2.62KB 1.18KB
plugin-report (index.js) 129.03KB 28.39KB
plugin-timeline (index.js) 25.37KB 7.20KB
plugin-view (index.js) 81.50KB 19.86KB
plugin-workflow (index.js) 69.35KB 14.42KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.55KB 0.67KB
providers (UploadProvider.js) 11.71KB 3.53KB
providers (index.js) 0.44KB 0.22KB
providers (types.js) 0.01KB 0.04KB
react (LazyPluginLoader.js) 3.77KB 1.33KB
react (SchemaRenderer.js) 14.98KB 4.84KB
react (index.js) 0.76KB 0.42KB
tenant (TenantContext.js) 0.31KB 0.25KB
tenant (TenantGuard.js) 1.04KB 0.43KB
tenant (TenantProvider.js) 2.76KB 0.98KB
tenant (TenantScopedQuery.js) 0.77KB 0.44KB
tenant (index.js) 0.75KB 0.38KB
tenant (resolver.js) 2.64KB 0.76KB
tenant (useTenant.js) 0.50KB 0.32KB
tenant (useTenantBranding.js) 0.62KB 0.39KB
types (ai.js) 0.20KB 0.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 2.87KB 0.99KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (complex.js) 0.20KB 0.18KB
types (crud.js) 0.20KB 0.18KB
types (data-display.js) 0.20KB 0.18KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 0.77KB 0.41KB
types (disclosure.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 0.20KB 0.18KB
types (form.js) 0.20KB 0.18KB
types (index.js) 1.54KB 0.68KB
types (layout.js) 0.20KB 0.18KB
types (mobile.js) 0.20KB 0.18KB
types (navigation.js) 0.20KB 0.18KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 0.20KB 0.18KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-components.js) 0.20KB 0.19KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (spec-report.js) 4.80KB 1.76KB
types (tenant.js) 0.20KB 0.18KB
types (theme.js) 0.20KB 0.18KB
types (ui-action.js) 0.75KB 0.46KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB
types (workflow.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@os-zhuang os-zhuang marked this pull request as ready for review June 6, 2026 07:21
@os-zhuang os-zhuang merged commit 7da8a57 into main Jun 6, 2026
10 checks passed
@os-zhuang os-zhuang deleted the claude/runtime-report-editor branch June 6, 2026 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants